From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#7464: 24.0.50; mouse highlighting vanishes upon unsplitting window Date: Sat, 24 Mar 2012 22:46:44 +0100 Message-ID: <87limpoenv.fsf@escher.home> References: <877hg5l828.fsf@escher.home> <8362vp9rci.fsf@gnu.org> <83y68l88xd.fsf@gnu.org> <87sjh12a0d.fsf@gnu.org> <871uolhmdx.fsf@escher.home> <83d381u9xy.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1332625696 29159 80.91.229.3 (24 Mar 2012 21:48:16 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 24 Mar 2012 21:48:16 +0000 (UTC) Cc: cyd@gnu.org, 7464@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 24 22:48:13 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SBYoi-0000MN-OQ for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Mar 2012 22:48:08 +0100 Original-Received: from localhost ([::1]:57550 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBYoh-0007rC-SB for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Mar 2012 17:48:07 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBYoe-0007r0-Ik for bug-gnu-emacs@gnu.org; Sat, 24 Mar 2012 17:48:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SBYoc-0003L2-Q4 for bug-gnu-emacs@gnu.org; Sat, 24 Mar 2012 17:48:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58669) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBYoc-0003Kq-M6 for bug-gnu-emacs@gnu.org; Sat, 24 Mar 2012 17:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SBZIc-0003FZ-6M for bug-gnu-emacs@gnu.org; Sat, 24 Mar 2012 18:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Mar 2012 22:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7464 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7464-submit@debbugs.gnu.org id=B7464.133262751112454 (code B ref 7464); Sat, 24 Mar 2012 22:19:02 +0000 Original-Received: (at 7464) by debbugs.gnu.org; 24 Mar 2012 22:18:31 +0000 Original-Received: from localhost ([127.0.0.1]:37268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SBZHz-0003Eh-Bn for submit@debbugs.gnu.org; Sat, 24 Mar 2012 18:18:30 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.22]:48034) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1SBZHQ-0003DS-Cj for 7464@debbugs.gnu.org; Sat, 24 Mar 2012 18:18:21 -0400 Original-Received: (qmail invoked by alias); 24 Mar 2012 21:46:46 -0000 Original-Received: from i59F54FFE.versanet.de (EHLO escher.home) [89.245.79.254] by mail.gmx.net (mp072) with SMTP; 24 Mar 2012 22:46:46 +0100 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX183XCEN3Vs3aIZxcF/KIpM7UG/iJC+wRAvE8Ji8ik A8OykxhGB9QRus In-Reply-To: <83d381u9xy.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 24 Mar 2012 20:32:09 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:58105 Archived-At: On Sat, 24 Mar 2012 20:32:09 +0200 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: Eli Zaretskii , 7464@debbugs.gnu.org >> Date: Wed, 21 Mar 2012 18:52:42 +0100 >> >> On Thu, 22 Mar 2012 00:29:06 +0800 Chong Yidong wrote: >> >> > Eli Zaretskii writes: >> > >> >>> > 1. emacs -q >> >>> > 2. C-x 2 >> >>> > 3. Put the mouse pointer over one of the links in the splash screen, so >> >>> > that the link becomes highlighted. >> >>> > 4. C-x 1 >> >>> > => The highlighting from step 3 disappears >> >>> >> >>> > This problem is reliably reproducible, also on earlier builds of Emacs >> >>> > 24 I have, but not on Emacs 23.1.91 (I don't have 23.2). >> >>> >> >>> I can reproduce it on Windows in Emacs 23.2.90 and also in stock Emacs >> >>> 23.2 and Emacs 23.1. I don't have Emacs 23.1.90 anymore to test. >> > >> > I can't reproduce this with latest trunk (x86_64-unknown-linux-gnu, GTK+ >> > Version 3.2.0). Maybe this has been fixed since the bug report? Eli, >> > could you check again, since you could reproduce it before? >> >> I just updated from the trunk and rebuilt (GNU Emacs 24.0.94.6 >> (i686-suse-linux-gnu, GTK+ Version 2.24.7) of 2012-03-21 on escher), and >> I can still reproduce the bug. > > I found why this happens. The lines ("glyph rows") in which some of > the glyphs are highlighted in mouse face are marked with a special > flag. This flag is checked by redisplay, and it tells redisplay that > when that row is redrawn, its mouse face should be restored. > > Now, "C-x 1" calls delete-other-windows-internal, which, as part of > its job, deletes the glyph matrices of the original window. With that > deletion, those flags of the highlighted rows are reset, i.e. the > information about the highlight stored in the glyph matrix is lost. > But no one tells redisplay that the mouse highlight was effectively > overwritten, and that it should arrange for it to be redisplayed. > > The patch below fixes that. I applied the patch and rebuilt, and confirm it fixes the bug; thanks. > Again, since this isn't a regression wrt > Emacs 23, I will not install it now unless Chong and Stefan decide I > should. According to my observations it is a regression, though I don't know why your observations differ from mine. Does your patch also fix Emacs 23 for you? Since the code involved changed significantly between Emacs 23 and 24, I'm curious if your fix also applies to Emacs 23 -- would it go before the invocation of free_window_matrices in delete_window? But if so, why do I not see the bug in Emacs 23? (And why does Chong Yidong not see it in Emacs 24?) Steve Berman