From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#12117: read-passwd deletes prompt Date: Tue, 07 Aug 2012 03:04:17 +0300 Organization: JURTA Message-ID: <87lihr7eke.fsf@mail.jurta.org> References: <87vcihuzdp.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1344297973 31431 80.91.229.3 (7 Aug 2012 00:06:13 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 7 Aug 2012 00:06:13 +0000 (UTC) Cc: 12117@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 07 02:06:13 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SyXJM-0004V6-JW for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Aug 2012 02:06:12 +0200 Original-Received: from localhost ([::1]:38967 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyXJL-0006YO-Rl for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Aug 2012 20:06:11 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyXJI-0006Y8-Ur for bug-gnu-emacs@gnu.org; Mon, 06 Aug 2012 20:06:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyXJG-0001aJ-Vo for bug-gnu-emacs@gnu.org; Mon, 06 Aug 2012 20:06:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56995) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyXJG-0001a2-Rk for bug-gnu-emacs@gnu.org; Mon, 06 Aug 2012 20:06:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SyXQv-0004L6-OO for bug-gnu-emacs@gnu.org; Mon, 06 Aug 2012 20:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Aug 2012 00:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12117-submit@debbugs.gnu.org id=B12117.134429839616619 (code B ref 12117); Tue, 07 Aug 2012 00:14:01 +0000 Original-Received: (at 12117) by debbugs.gnu.org; 7 Aug 2012 00:13:16 +0000 Original-Received: from localhost ([127.0.0.1]:38308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SyXQB-0004Jz-UX for submit@debbugs.gnu.org; Mon, 06 Aug 2012 20:13:16 -0400 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:58355 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SyXQ8-0004Jq-Ej for 12117@debbugs.gnu.org; Mon, 06 Aug 2012 20:13:14 -0400 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id AF6AD451CACA; Mon, 6 Aug 2012 17:05:15 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Mon, 06 Aug 2012 18:00:09 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:62891 Archived-At: > Hmm... I guess the problem is even more general: any minibuffer input > during insert-file-contents will suffer from it (granted, there usually > isn't much minibuffer input during such calls, luckily). > > Maybe read-from-minibuffer should let-bind inhibit-read-only to nil? > That sounds ugly, tho. Since there is not much minibuffer input during insert-file-contents (one is known at the moment) then perhaps it would be safer to fix just these places specific to insert-file-contents: === modified file 'lisp/epa.el' --- lisp/epa.el 2012-06-08 16:39:49 +0000 +++ lisp/epa.el 2012-08-07 00:01:14 +0000 @@ -589,6 +589,10 @@ (defun epa-display-verify-result (verify (make-obsolete 'epa-display-verify-result 'epa-display-info "23.1") (defun epa-passphrase-callback-function (context key-id handback) + ;; Bind `inhibit-read-only' to nil because `find-file-noselect-1' binds + ;; it to t (for `insert-file-contents') that allows the user to delete + ;; characters in the read-only minibuffer prompt in `read-passwd'. + (let ((inhibit-read-only nil)) (if (eq key-id 'SYM) (read-passwd (format "Passphrase for symmetric encryption%s: " @@ -603,7 +607,7 @@ (defun epa-passphrase-callback-function (let ((entry (assoc key-id epg-user-id-alist))) (if entry (format "Passphrase for %s %s: " key-id (cdr entry)) - (format "Passphrase for %s: " key-id))))))) + (format "Passphrase for %s: " key-id)))))))) (defun epa-progress-callback-function (_context what _char current total handback)