From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Recent keyboard changes breaks quitting Date: Sat, 22 Sep 2012 22:51:20 +0800 Message-ID: <87lig22jrr.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1348325504 3599 80.91.229.3 (22 Sep 2012 14:51:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 22 Sep 2012 14:51:44 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 22 16:51:44 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TFR3X-0004lE-BJ for ged-emacs-devel@m.gmane.org; Sat, 22 Sep 2012 16:51:43 +0200 Original-Received: from localhost ([::1]:60925 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFR3S-0006LH-Nn for ged-emacs-devel@m.gmane.org; Sat, 22 Sep 2012 10:51:38 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFR3N-0006Kw-Qx for emacs-devel@gnu.org; Sat, 22 Sep 2012 10:51:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFR3H-0000mo-UP for emacs-devel@gnu.org; Sat, 22 Sep 2012 10:51:33 -0400 Original-Received: from mail-pb0-f41.google.com ([209.85.160.41]:58551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFR3H-0000mj-N3; Sat, 22 Sep 2012 10:51:27 -0400 Original-Received: by pbbro12 with SMTP id ro12so10571555pbb.0 for ; Sat, 22 Sep 2012 07:51:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:mime-version:content-type; bh=HwOr8sQzgfzOIpj3eqpcxn9EyLtWjNN2TP2hDg7A1n8=; b=aoByXzdwsrcCWjXWkV7LkuTRgEY70eH5tdMCY0sxaodDgc1xROfymtnFBhHjnK8t2o diZS3STjjEpK7YhmEBZho0m7hqoFpqFg0NfjjtJyL8kgC1lyplVb/JmII9DknPU88HyX HWZEpCxrlJigW7bw0PZvxpkPdYJsY/m6+fIedUdGFwpKuSBuIpZ4gcEghWOgs6rxv3Zd pbt7F5VbLIZZ5k6wbl3SO6syzvC5PP1U2671FQ0jMe2vL3s44XPyKo5EXKxyPK9t8dbY fAyCHDV28X09IWR6wz0e0ntD0nA2KcnTSSDmBCdIgTLk6w3aX/bJTDFhTP762X9G6EBX 9BXg== Original-Received: by 10.68.224.73 with SMTP id ra9mr23625141pbc.85.1348325486338; Sat, 22 Sep 2012 07:51:26 -0700 (PDT) Original-Received: from ulysses (cm162.gamma80.maxonline.com.sg. [202.156.80.162]) by mx.google.com with ESMTPS id it5sm6769446pbc.10.2012.09.22.07.51.23 (version=SSLv3 cipher=OTHER); Sat, 22 Sep 2012 07:51:25 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.160.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153464 Archived-At: Hi Eli, somehow your latest changes to keyboard.c broke quitting: M-x C-g => The cursor remains in the minibuffer. A second C-g is needed to exit the minibuffer. I verified that this behavior was introduced by revno: 110138 fixes bugs: http://debbugs.gnu.org/12447 http://debbugs.gnu.org/12326 committer: Eli Zaretskii branch nick: trunk timestamp: Sat 2012-09-22 16:16:03 +0300 message: Fix bugs #12447 and #12326 with infloop causes by idle timers, update docs. src/keyboard.c (timer_check_2): Move calculation of 'timers' and 'idle_timers' from here ... (timer_check): ... to here. Use Fcopy_sequence to copy the timer lists, to avoid infloops when the timer does something stupid, like reinvoke itself with the same or smaller time-out. lisp/emacs-lisp/timer.el (run-with-idle-timer) (timer-activate-when-idle): Warn against reinvoking an idle timer from within its own timer action. doc/lispref/os.texi (Idle Timers): Warn against reinvoking an idle timer from within its own timer action.