bug#12514: 24.2; message-make-date returns a localized date after X restart

[Marco Pessotto <melmothx@gmail.com>]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> This is the definition of `message-make-date', so this seems rather odd:
>
> (defun message-make-date (&optional now)
>   "Make a valid data header.
> If NOW, use that time instead."
>   (let ((system-time-locale "C"))
>     (format-time-string "%a, %d %b %Y %T %z" now)))
>
> Are you picking up a very old version of message.el from somewhere,
> perhaps?  Or are you redefining `message-make-date'?

No and no. "Library is file /usr/share/emacs/23.2/lisp/gnus/message.elc"

I run GNU Emacs shipped with Debian. GNU Emacs 23.2.1
(i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2010-12-11 on
raven, modified by Debian.

I can reliably reproduce this bug on my box with the receipt provided.
My workaround was to put something like this in .xinitrc:

emacsclient -e '(let ((system-time-locale "C")) (format-time-string "%a,
%d %b %Y %T %z"))'

After the apparently useless evaluation, everything is back to normal.
From what I can see, the bug is deep inside the C code or related
libraries shipped by Debian, as the Lisp looks quite fine (I did some
source-diving myself).

I can reproduce it reliably with emacs 24.2 too.

; start emacs
emacs --daemon
emacsclient -c -n

; start gnus

; evaluate: everything fine
(message-make-date)
"Tue, 25 Dec 2012 17:44:53 +0100"

; kill X and leave the daemon alive
; bring the emacs back with emacsclient -c -n


; evaluate first time, here we have the broken header
(message-make-date)
"mar, 25 dic 2012 17:45:40 +0100"

(emacs-version)
"GNU Emacs 24.2.2 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2012-12-25 on universe"

; and now we're back to normal, after the first evaluation
(message-make-date)
"Tue, 25 Dec 2012 17:46:23 +0100"

(gnus-version)
"Gnus v5.13"

Please let me know if I can help in some way.

Best wishes and thanks for your awesome work.

-- 
Marco