From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ari Roponen Newsgroups: gmane.emacs.bugs Subject: bug#13345: 24.2.91; Wrong assumption in a hash table example + fix Date: Thu, 03 Jan 2013 14:01:17 +0200 Message-ID: <87lica79wy.fsf@arirop.lan> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1357214715 14403 80.91.229.3 (3 Jan 2013 12:05:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Jan 2013 12:05:15 +0000 (UTC) To: 13345@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 03 13:05:31 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TqjY8-0000VE-8d for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Jan 2013 13:05:28 +0100 Original-Received: from localhost ([::1]:55167 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqjXs-0000wn-LZ for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Jan 2013 07:05:12 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:49109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqjXR-0000qK-1H for bug-gnu-emacs@gnu.org; Thu, 03 Jan 2013 07:05:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TqjWk-0000Zh-95 for bug-gnu-emacs@gnu.org; Thu, 03 Jan 2013 07:04:44 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59189) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqjWk-0000Zb-4f for bug-gnu-emacs@gnu.org; Thu, 03 Jan 2013 07:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TqjWk-0006fu-Fc for bug-gnu-emacs@gnu.org; Thu, 03 Jan 2013 07:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ari Roponen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Jan 2013 12:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.135721461525621 (code B ref -1); Thu, 03 Jan 2013 12:04:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 Jan 2013 12:03:35 +0000 Original-Received: from localhost ([127.0.0.1]:41207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TqjWH-0006fA-DO for submit@debbugs.gnu.org; Thu, 03 Jan 2013 07:03:34 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:37480) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TqjWF-0006f3-4F for submit@debbugs.gnu.org; Thu, 03 Jan 2013 07:03:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TqjVb-0000Em-S1 for submit@debbugs.gnu.org; Thu, 03 Jan 2013 07:03:30 -0500 Original-Received: from lists.gnu.org ([208.118.235.17]:36483) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqjVb-0000Eg-Mw for submit@debbugs.gnu.org; Thu, 03 Jan 2013 07:02:51 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:48658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqjUx-0000VE-Lh for bug-gnu-emacs@gnu.org; Thu, 03 Jan 2013 07:02:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TqjUI-0008S4-1S for bug-gnu-emacs@gnu.org; Thu, 03 Jan 2013 07:02:11 -0500 Original-Received: from mail-la0-f50.google.com ([209.85.215.50]:64222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqjUH-0008Rs-QX for bug-gnu-emacs@gnu.org; Thu, 03 Jan 2013 07:01:29 -0500 Original-Received: by mail-la0-f50.google.com with SMTP id fs13so7557889lab.23 for ; Thu, 03 Jan 2013 04:01:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:subject:date:message-id:mime-version :content-type; bh=LmSuYEzDABL5c7y5b+egEe52PYOKt8hJc3K7SLJz84c=; b=pDl6RaHCqHLnARUYBRAoTNgQqxG/l16y+OyDhEmRfCettaKLyiBMWlNBOKRQDYHIBs kenznYV3zLMxvyaR6CVlr/1KOmSqrD3qCcZtkpGWL45KpAF0YXyts57d2gWDm+rCGgwN jexlrFV+CdF98sxixDjMpzUbGr2p40Ok9mBrXwLn1XXEG+BQtc3AUlvK1H4IEAFZZdb5 ThOGFqHT9EBIrHFZQaMB7U3fTtmWINbYo1st39ISK4PnXgaivisZpav5rYxZ2mc/PpeL wbFipmajR01l3SUmCczbrE2FvlVX7IwlcxWIbuPdW4sG4dYAMbjzOMnSuowOVM3EKk/O g2OQ== X-Received: by 10.112.10.3 with SMTP id e3mr20151868lbb.33.1357214488319; Thu, 03 Jan 2013 04:01:28 -0800 (PST) Original-Received: from arirop.lan (dsl-jklbrasgw1-54fb0b-115.dhcp.inet.fi. [84.251.11.115]) by mx.google.com with ESMTPS id sj3sm18339059lab.2.2013.01.03.04.01.24 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 Jan 2013 04:01:25 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:69330 Archived-At: In file doc/lispref/hash.texi, there is an example: @example (defun case-fold-string= (a b) (compare-strings a nil nil b nil nil t)) (defun case-fold-string-hash (a) (sxhash (upcase a))) (define-hash-table-test 'case-fold 'case-fold-string= 'case-fold-string-hash) (make-hash-table :test 'case-fold) @end example The documentation of `define-hash-table-test' says: The function @var{test-fn} should accept two arguments, two keys, and return non-@code{nil} if they are considered ``the same''. In the above example, the test function returns always non-nil, because it assumes `compare-strings' returns nil for differing strings. The patch below fixes this wrong assumption. 2013-01-03 Ari Roponen (tiny change) * hash.texi (Defining Hash): Fix example. === modified file 'doc/lispref/hash.texi' --- doc/lispref/hash.texi 2013-01-01 09:11:05 +0000 +++ doc/lispref/hash.texi 2013-01-03 10:50:19 +0000 @@ -293,7 +293,7 @@ @example (defun case-fold-string= (a b) - (compare-strings a nil nil b nil nil t)) + (eq t (compare-strings a nil nil b nil nil t))) (defun case-fold-string-hash (a) (sxhash (upcase a))) In GNU Emacs 24.2.91.9 (x86_64-unknown-linux-gnu, GTK+ Version 3.7.2) of 2013-01-03 on arirop Bzr revision: 111125 rgm@gnu.org-20130103063325-sx99hs1usiuqlxvb Windowing system distributor `Fedora Project', version 11.0.11300000 System Description: Fedora release 18 (Spherical Cow) -- Ari Roponen