all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Bastien <bzg@altern.org>
To: Reuben Thomas <rrt@sc3d.org>
Cc: 13567@debbugs.gnu.org
Subject: bug#13567: 24.1; New remember back-end for storing data in multiple files
Date: Sun, 14 Apr 2013 09:06:35 +0200	[thread overview]
Message-ID: <87li8ld1ad.fsf@bzg.ath.cx> (raw)
In-Reply-To: <87sj5m5wga.fsf@sc3d.org> (Reuben Thomas's message of "Sun, 27 Jan 2013 18:09:57 +0000")

Hi,

Reuben Thomas <rrt@sc3d.org> writes:

> I prefer to store my ideas in individual files rather than one big file;
> a simplified version of remember-store-in-mailbox achieves this:
>
> ;; Remember support for storing remember data in individual files.
> (defcustom remember-directory "~/remember"
>   "The directory in which to store remember data as files."
>   :type 'file
>   :group 'remember)

Better use remember-data-directory since there is remember-data-file?

> (defcustom remember-directory-file-name-format "%Y-%m-%d_%T-%z"
>   "The file in which to store unprocessed data."
>   :type 'file
>   :group 'remember)

The docstring needs an update.

> (defcustom remember-handler-functions '(remember-append-to-file)
>   "Functions run to process remember data.
> Each function is called with the current buffer narrowed to what the
> user wants remembered.
> If any function returns non-nil, the data is assumed to have been
> recorded somewhere by that function. "
>   :type 'hook
>   :options '(remember-store-in-mailbox
>              remember-append-to-file
>              remember-store-in-files
>              remember-diary-extract-entries
>              org-remember-handler)
>   :group 'remember)
>
> (defun remember-store-in-files ()
>   "Store remember data in a file in the directory `remember-directory',
> in a file named by `remember-directory-file-name-format' fed through
> `format-time-string'."

The first line of the docstring should be a sentence.
You can use M-x checkdoc RET to catch those docstring errors.

>   (let ((moment (format-time-string remember-directory-file-name-format (current-time)))
>         (text (buffer-string)))
>     (with-temp-buffer
>       (insert text)
>       (write-file (convert-standard-filename
>                    (format "%s/%s" remember-directory moment))))))
>
> If you can use this code, I've already signed an Emacs copyright
> waiver.

Looks okay to me -- can you provide the change as a patch against
current remember.el?

Thanks,

-- 
 Bastien





  parent reply	other threads:[~2013-04-14  7:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-27 18:09 bug#13567: 24.1; New remember back-end for storing data in multiple files Reuben Thomas
2013-04-11 20:13 ` Reuben Thomas
2013-04-11 20:20   ` bug#13567: Fwd: " Reuben Thomas
2013-04-14  7:06 ` Bastien [this message]
2013-04-14 20:16   ` bug#13567: " Reuben Thomas
2013-04-24 14:37     ` Bastien
2013-04-24 16:50       ` Glenn Morris
2013-04-25 17:42         ` Bastien
2013-04-26  0:51           ` Glenn Morris
2013-04-26  7:01             ` Bastien
2013-04-26  7:44               ` Reuben Thomas
2013-04-26  7:47                 ` Bastien
2013-04-26 23:57             ` Reuben Thomas
2013-04-27 15:38               ` Josh
2013-04-27 15:43                 ` Reuben Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87li8ld1ad.fsf@bzg.ath.cx \
    --to=bzg@altern.org \
    --cc=13567@debbugs.gnu.org \
    --cc=rrt@sc3d.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.