Re: /srv/bzr/emacs/trunk r112822: * eshell/esh-ext.el (eshell-external-command): Pass args to

Re: /srv/bzr/emacs/trunk r112822: * eshell/esh-ext.el (eshell-external-command): Pass args to

[Glenn Morris]

Tassilo Horn wrote:

> ------------------------------------------------------------
> +			     (intersection args

em-term.el:321:1:Warning: the function `intersection' is not known to be
    defined.

Re: /srv/bzr/emacs/trunk r112822: * eshell/esh-ext.el (eshell-external-command): Pass args to

[Glenn Morris]

PS please add a NEWS entry.

Re: /srv/bzr/emacs/trunk r112822: * eshell/esh-ext.el (eshell-external-command): Pass args to

[Tassilo Horn]

Glenn Morris <rgm@gnu.org> writes:

Hi Glenn,

>> ------------------------------------------------------------
>> +			     (intersection args
>
> em-term.el:321:1:Warning: the function `intersection' is not known to be
>     defined.

Thanks for the heads up.  I've changed it to `cl-intersection'.  And
thanks for adding the missing :version tags to the new defcustoms.

Bye,
Tassilo

Re: /srv/bzr/emacs/trunk r112822: * eshell/esh-ext.el (eshell-external-command): Pass args to

[Tassilo Horn]

Glenn Morris <rgm@gnu.org> writes:

> PS please add a NEWS entry.

Done.

Bye,
Tassilo

Re: /srv/bzr/emacs/trunk r112822: * eshell/esh-ext.el (eshell-external-command): Pass args to

[Glenn Morris]

Tassilo Horn wrote:

> Thanks for the heads up.  I've changed it to `cl-intersection'.

You still need to actually require cl-lib.

Re: /srv/bzr/emacs/trunk r112822: * eshell/esh-ext.el (eshell-external-command): Pass args to

[Tassilo Horn]

Glenn Morris <rgm@gnu.org> writes:

> Tassilo Horn wrote:
>
>> Thanks for the heads up.  I've changed it to `cl-intersection'.
>
> You still need to actually require cl-lib.

Really?  It says

  cl-intersection is an *autoloaded* compiled Lisp function in
  `cl-seq.el'.

Bye,
Tassilo

Re: /srv/bzr/emacs/trunk r112822: * eshell/esh-ext.el (eshell-external-command): Pass args to

[Glenn Morris]

Tassilo Horn wrote:

> Really?  It says
>
>   cl-intersection is an *autoloaded* compiled Lisp function in
>   `cl-seq.el'.

Yes, really. Is it so hard to run emacs -Q?
It is autoloaded from cl-seq once you load cl-lib.

(I suppose this is an instance where the "is an autoloaded function"
blurb is not that useful.)

Re: /srv/bzr/emacs/trunk r112822: * eshell/esh-ext.el (eshell-external-command): Pass args to

[Tassilo Horn]

Glenn Morris <rgm@gnu.org> writes:

>> Really?  It says
>>
>>   cl-intersection is an *autoloaded* compiled Lisp function in
>>   `cl-seq.el'.
>
> Yes, really.

Ok, I added a require.

> Is it so hard to run emacs -Q?

Rest assured I did that.  em-term.el requires esh-ext which already
requires cl-lib.  So neither do you get an error at runtime nor a
warning when compiling...

Bye,
Tassilo

Re: /srv/bzr/emacs/trunk r112822: * eshell/esh-ext.el (eshell-external-command): Pass args to

[Glenn Morris]

Tassilo Horn wrote:

> em-term.el requires esh-ext which already requires cl-lib.

Only at compile time, not at runtime.

> So neither do you get an error at runtime nor a warning when
> compiling...

Previously, the only thing in eshell that required cl-lib at run-time
was em-ls. So if you remove eshell-ls from the list of eshell modules:

emacs -Q --eval "(setq eshell-modules-list '(eshell-alias eshell-banner
 eshell-basic eshell-cmpl eshell-dirs eshell-glob eshell-hist eshell-pred
 eshell-prompt eshell-script eshell-term eshell-unix))" -f eshell

there was indeed an error at runtime.

I don't know why there is no warning during bootstrap, but there is
a warning from a built emacs:

emacs -Q -batch -f batch-byte-compile em-term.el

In end of data:
em-term.el:321:1:Warning: the function `cl-intersection' is not known to
  be defined.

Hmm, looks like you get a warning only if esh-ext.el is already compiled
when you compiled em-term.el. I think this might be a (recent) compiler
bug, maybe my 2013-05-22 change?

Pedantically yours,

Re: /srv/bzr/emacs/trunk r112822: * eshell/esh-ext.el (eshell-external-command): Pass args to

[Glenn Morris]

Glenn Morris wrote:

> Hmm, looks like you get a warning only if esh-ext.el is already compiled
> when you compiled em-term.el. I think this might be a (recent) compiler
> bug, maybe my 2013-05-22 change?

No, looks like it always been like that.
I filed http://debbugs.gnu.org/14551 but it's probably unfixable (?).

Re: /srv/bzr/emacs/trunk r112822: * eshell/esh-ext.el (eshell-external-command): Pass args to

[Tassilo Horn]

Glenn Morris <rgm@gnu.org> writes:

>> em-term.el requires esh-ext which already requires cl-lib.
>
> Only at compile time, not at runtime.

Oh, right.  I confused the "equivalent to progn in interpreted code" in
the docstring of `eval-when-compile' with "at runtime", which is of
course wrong.

>> So neither do you get an error at runtime nor a warning when
>> compiling...
>
> Previously, the only thing in eshell that required cl-lib at run-time
> was em-ls. So if you remove eshell-ls from the list of eshell modules:
>
> emacs -Q --eval "(setq eshell-modules-list '(eshell-alias eshell-banner
>  eshell-basic eshell-cmpl eshell-dirs eshell-glob eshell-hist eshell-pred
>  eshell-prompt eshell-script eshell-term eshell-unix))" -f eshell
>
> there was indeed an error at runtime.
>
> I don't know why there is no warning during bootstrap, but there is
> a warning from a built emacs:
>
> emacs -Q -batch -f batch-byte-compile em-term.el
>
> In end of data:
> em-term.el:321:1:Warning: the function `cl-intersection' is not known to
>   be defined.
>
> Hmm, looks like you get a warning only if esh-ext.el is already compiled
> when you compiled em-term.el. I think this might be a (recent) compiler
> bug, maybe my 2013-05-22 change?
>
> Pedantically yours,

Thanks for the explanation.

Bye,
Tassilo