From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenjiro NAKAYAMA Newsgroups: gmane.emacs.devel Subject: Re: trunk r115246: eww usability improvements Date: Sun, 08 Dec 2013 15:02:40 +0900 Message-ID: <87lhzvq3r3.fsf@dhcp-193-97.nrt.redhat.com> References: <87iovbxnj2.fsf@flea.lifelogs.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1386482584 10643 80.91.229.3 (8 Dec 2013 06:03:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 8 Dec 2013 06:03:04 +0000 (UTC) Cc: "T.V. Raman" , Lars Magne Ingebrigtsen , Ted Zlatanov , emacs-devel@gnu.org To: Nakayama Kenjiro Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 08 07:03:09 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VpXSP-0003Sy-3c for ged-emacs-devel@m.gmane.org; Sun, 08 Dec 2013 07:03:09 +0100 Original-Received: from localhost ([::1]:38272 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VpXSO-0000lT-LP for ged-emacs-devel@m.gmane.org; Sun, 08 Dec 2013 01:03:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56370) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VpXSC-0000lD-W6 for emacs-devel@gnu.org; Sun, 08 Dec 2013 01:03:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VpXS2-0001ED-IX for emacs-devel@gnu.org; Sun, 08 Dec 2013 01:02:56 -0500 Original-Received: from mail-pd0-x230.google.com ([2607:f8b0:400e:c02::230]:33584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VpXS2-0001Dh-CO for emacs-devel@gnu.org; Sun, 08 Dec 2013 01:02:46 -0500 Original-Received: by mail-pd0-f176.google.com with SMTP id w10so3288405pde.21 for ; Sat, 07 Dec 2013 22:02:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-type; bh=zwmO6sTAlBo25S32fERZ0YRYSOe9vlQalXqin29WUkw=; b=S+4tCCaJEue8lBP4Tt76eEbHAx/GN6EVVDvP1jBgyXj3YCFXKKEl+6SAi4UdWHvTou KlZIwT2DfKrfR7WEriyedsve1NYy7yi/JMcpOAO3EXYvDnTG0h1hBpGH/1O+kEMNv57q pBn8rRmsGmPeeYfbjvGu0/1rCEFa0YS73CTCgp3himaBgLI76RtD16P2c3h3F5FcI95b fCh6ni4e76chiUiKUybXZmzQdOlwCnNK1YPlXVuUVqeMZcrITHLj52J+JnQFBB8OgZxo xMT+JsN5Lh68O+qJ1DnOUl6Akmb1Sd/1TOE7XV/RSFYxslb/4ndUibpQkLWfUAz8dYSL YdqA== X-Received: by 10.68.198.97 with SMTP id jb1mr13623619pbc.104.1386482565362; Sat, 07 Dec 2013 22:02:45 -0800 (PST) Original-Received: from dhcp-193-97.nrt.redhat.com (nat-pool-nrt-u1.redhat.com. [66.187.238.11]) by mx.google.com with ESMTPSA id ha10sm8665984pbd.17.2013.12.07.22.02.42 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Dec 2013 22:02:44 -0800 (PST) User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.3 In-reply-to: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c02::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:166195 Archived-At: Sorry, I have One more thing. if we use quit-window to quit eww, the following two lines in eww-mode-map should be deleted? After restart eww, we can use the eww-history. (set (make-local-variable 'eww-history) nil) (set (make-local-variable 'eww-history-position) 0) I sent the patch with the new function to list the browser histories to bug-gnu-emacs mailing list (bug#16086). Kenjiro NAKAYAMA nakayamakenjiro@gmail.com writes: > I found another tiny mistake in easy-menu. I resend the fixes. > > Signed-off-by: Kenjiro NAKAYAMA > > * net/eww.el (eww-mode-map): "Quit" in the easy-menu do a > `quit-window' instead of killing the buffer. And fixed wrong function of > "List bookmarks". > > --- > lisp/net/eww.el | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lisp/net/eww.el b/lisp/net/eww.el > index 9d1c3a2..0c6513e 100644 > --- a/lisp/net/eww.el > +++ b/lisp/net/eww.el > @@ -418,7 +418,7 @@ word(s) will be searched for via `eww-search-prefix'." > > (easy-menu-define nil map "" > '("Eww" > - ["Quit" eww-quit t] > + ["Quit" quit-window t] > ["Reload" eww-reload t] > ["Back to previous page" eww-back-url > :active (not (zerop (length eww-history)))] > @@ -429,7 +429,7 @@ word(s) will be searched for via `eww-search-prefix'." > ["View page source" eww-view-source] > ["Copy page URL" eww-copy-page-url t] > ["Add bookmark" eww-add-bookmark t] > - ["List bookmarks" eww-copy-page-url t] > + ["List bookmarks" eww-list-bookmarks t] > ["List cookies" url-cookie-list t])) > map))