From: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
To: Nakayama Kenjiro <nakayamakenjiro@gmail.com>
Cc: "T.V. Raman" <tv.raman.tv@gmail.com>,
Lars Magne Ingebrigtsen <larsi@gnus.org>,
Ted Zlatanov <tzz@lifelogs.com>,
emacs-devel@gnu.org
Subject: Re: trunk r115246: eww usability improvements
Date: Sun, 08 Dec 2013 15:02:40 +0900 [thread overview]
Message-ID: <87lhzvq3r3.fsf@dhcp-193-97.nrt.redhat.com> (raw)
In-Reply-To: <CAA_ZtA-bbCwJcAOpj4xPPPpbp4kkaHHzE0bZJwm9S6fqbxiu1w@mail.gmail.com>
Sorry, I have One more thing. if we use quit-window to quit eww, the following two lines in
eww-mode-map should be deleted? After restart eww, we can use the eww-history.
(set (make-local-variable 'eww-history) nil)
(set (make-local-variable 'eww-history-position) 0)
I sent the patch with the new function to list the browser histories
to bug-gnu-emacs mailing list (bug#16086).
Kenjiro NAKAYAMA
nakayamakenjiro@gmail.com writes:
> I found another tiny mistake in easy-menu. I resend the fixes.
>
> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
>
> * net/eww.el (eww-mode-map): "Quit" in the easy-menu do a
> `quit-window' instead of killing the buffer. And fixed wrong function of
> "List bookmarks".
>
> ---
> lisp/net/eww.el | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/net/eww.el b/lisp/net/eww.el
> index 9d1c3a2..0c6513e 100644
> --- a/lisp/net/eww.el
> +++ b/lisp/net/eww.el
> @@ -418,7 +418,7 @@ word(s) will be searched for via `eww-search-prefix'."
>
> (easy-menu-define nil map ""
> '("Eww"
> - ["Quit" eww-quit t]
> + ["Quit" quit-window t]
> ["Reload" eww-reload t]
> ["Back to previous page" eww-back-url
> :active (not (zerop (length eww-history)))]
> @@ -429,7 +429,7 @@ word(s) will be searched for via `eww-search-prefix'."
> ["View page source" eww-view-source]
> ["Copy page URL" eww-copy-page-url t]
> ["Add bookmark" eww-add-bookmark t]
> - ["List bookmarks" eww-copy-page-url t]
> + ["List bookmarks" eww-list-bookmarks t]
> ["List cookies" url-cookie-list t]))
> map))
next prev parent reply other threads:[~2013-12-08 6:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1VlOsW-00006u-Ph@vcs.savannah.gnu.org>
2013-11-28 18:43 ` trunk r115246: eww usability improvements Lars Magne Ingebrigtsen
2013-11-29 14:58 ` Ted Zlatanov
2013-11-29 17:05 ` Stefan Monnier
2013-11-29 22:20 ` Ted Zlatanov
2013-11-30 2:04 ` Stefan Monnier
2013-12-01 13:13 ` Lars Magne Ingebrigtsen
2013-11-30 15:49 ` T.V. Raman
2013-12-01 17:00 ` Lars Magne Ingebrigtsen
2013-12-04 15:41 ` Ted Zlatanov
2013-12-05 3:35 ` T.V. Raman
2013-12-05 14:29 ` Ted Zlatanov
2013-12-05 16:57 ` T.V. Raman
2013-12-08 2:40 ` Nakayama Kenjiro
2013-12-08 3:03 ` Nakayama Kenjiro
2013-12-08 6:02 ` Kenjiro NAKAYAMA [this message]
2013-12-11 0:30 ` Ted Zlatanov
2013-12-11 5:00 ` nakayamakenjiro
2013-12-11 19:02 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhzvq3r3.fsf@dhcp-193-97.nrt.redhat.com \
--to=nakayamakenjiro@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=tv.raman.tv@gmail.com \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.