From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mario Lang Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] eww-mode-map doesn't bind TAB on tty. Date: Wed, 05 Mar 2014 16:02:54 +0100 Message-ID: <87lhwor8m9.fsf@fx.delysid.org> References: <87zjlbtnuw.fsf@fx.delysid.org> <87fvmx7nym.fsf@building.gnus.org> <83ppm1ralm.fsf@gnu.org> <83ob1lracq.fsf@gnu.org> <87d2i0zund.fsf@building.gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1394031836 6737 80.91.229.3 (5 Mar 2014 15:03:56 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 5 Mar 2014 15:03:56 +0000 (UTC) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 05 16:04:04 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WLDMV-0006Cx-IX for ged-emacs-devel@m.gmane.org; Wed, 05 Mar 2014 16:03:59 +0100 Original-Received: from localhost ([::1]:52730 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLDMV-0004V6-5R for ged-emacs-devel@m.gmane.org; Wed, 05 Mar 2014 10:03:59 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLDMM-0004Mp-91 for emacs-devel@gnu.org; Wed, 05 Mar 2014 10:03:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLDMG-0002Ql-7H for emacs-devel@gnu.org; Wed, 05 Mar 2014 10:03:50 -0500 Original-Received: from fep14.mx.upcmail.net ([62.179.121.34]:45788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLDMF-000294-RB for emacs-devel@gnu.org; Wed, 05 Mar 2014 10:03:44 -0500 Original-Received: from edge03.upcmail.net ([192.168.13.238]) by viefep14-int.chello.at (InterMail vM.8.01.05.05 201-2260-151-110-20120111) with ESMTP id <20140305150301.QHBB19242.viefep14-int.chello.at@edge03.upcmail.net>; Wed, 5 Mar 2014 16:03:01 +0100 Original-Received: from fx.delysid.org ([80.109.200.215]) by edge03.upcmail.net with edge id Zr301n01y4fLMH403r30Jr; Wed, 05 Mar 2014 16:03:01 +0100 X-SourceIP: 80.109.200.215 Original-Received: from mlang by fx.delysid.org with local (Exim 4.82) (envelope-from ) id 1WLDLU-0003tt-0d; Wed, 05 Mar 2014 16:02:56 +0100 In-Reply-To: <87d2i0zund.fsf@building.gnus.org> (Lars Ingebrigtsen's message of "Wed, 05 Mar 2014 13:39:50 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 62.179.121.34 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:170158 Archived-At: Lars Ingebrigtsen writes: > Eli Zaretskii writes: > >>> [tab] is a function key, not the character TAB. Try ?\t instead. >> >> And [?\M-\t] for backtab. > > Right; thanks. `eww-text-map', `eww-textarea-map' and `shr-map' likely have the same problem as `eww-mode-map' used to have: --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -592,8 +592,8 @@ appears in a or tag." (define-key map [(control a)] 'eww-beginning-of-text) (define-key map [(control c) (control c)] 'eww-submit) (define-key map [(control e)] 'eww-end-of-text) - (define-key map [tab] 'shr-next-link) - (define-key map [backtab] 'shr-previous-link) + (define-key map [?\t] 'shr-next-link) + (define-key map [?\M-\t] 'shr-previous-link) map)) =20 (defvar eww-textarea-map @@ -601,8 +601,8 @@ appears in a or tag." (set-keymap-parent map text-mode-map) (define-key map "\r" 'forward-line) (define-key map [(control c) (control c)] 'eww-submit) - (define-key map [tab] 'shr-next-link) - (define-key map [backtab] 'shr-previous-link) + (define-key map [?\t] 'shr-next-link) + (define-key map [?\M-\t] 'shr-previous-link) map)) =20 (defvar eww-select-map --- a/lisp/net/shr.el +++ b/lisp/net/shr.el @@ -147,8 +147,8 @@ cid: URL as the argument.") (define-key map "a" 'shr-show-alt-text) (define-key map "i" 'shr-browse-image) (define-key map "z" 'shr-zoom-image) - (define-key map [tab] 'shr-next-link) - (define-key map [backtab] 'shr-previous-link) + (define-key map [?\t] 'shr-next-link) + (define-key map [?\M-\t] 'shr-previous-link) (define-key map [follow-link] 'mouse-face) (define-key map [mouse-2] 'shr-browse-url) (define-key map "I" 'shr-insert-image) And here is the result of grepping for the pattern in all Emacs Lisp files: lisp/calendar/todo-mode.el: (define-key map [tab] 'todo-next-button) lisp/eshell/em-cmpl.el: (define-key eshell-command-map [tab] 'pcomplete-ex= pand-and-complete) lisp/eshell/em-cmpl.el: (define-key eshell-mode-map [tab] 'eshell-pcomplet= e) lisp/gnus/gnus-html.el: (define-key map [tab] 'widget-forward) lisp/image-dired.el: (define-key image-dired-thumbnail-mode-map [tab] 'ima= ge-dired-jump-original-dired-buffer) lisp/image-dired.el: (define-key dired-mode-map [tab] 'image-dired-jump-th= umbnail-buffer) lisp/international/quail.el: (define-key map [tab] 'quail-completion) lisp/kmacro.el: (define-key map [tab] 'act-repeat) lisp/play/5x5.el: (define-key map [tab] #'5x5-right) --=20 CYa, =E2=A1=8D=E2=A0=81=E2=A0=97=E2=A0=8A=E2=A0=95