all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Thien-Thi Nguyen <ttn@gnu.org>
To: toby-predictive@dr-qubit.org
Cc: emacs-devel@gnu.org
Subject: ELPA queue.el weirdness
Date: Wed, 14 May 2014 20:25:01 +0200	[thread overview]
Message-ID: <87lhu4tdz6.fsf@zigzag.favinet> (raw)

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

I see that the GNU ELPA packages/queue/queue.el has the following:

 (defmacro queue-empty (queue)
   "Return t if QUEUE is empty, otherwise return nil."
   (null (queue-head queue)))
 
 (defmacro queue-first (queue)
   "Return the first element of QUEUE or nil if it is empty,
 without removing it from the QUEUE."
   (car (queue-head queue)))

I don't understand how these can work in their present
formulation, and think they should be changed to use either
‘backquote’ and ‘unquote’, or (preferably) ‘defsubst’.

Also i notice that the queue.el from the www.dr-qubit.org Git repo
includes ‘lexical-binding: t’ whereas the ELPA version does not.

Do you have any plans to do these small changes and release (on
the ELPA side, that is) a new version?  If not, any objections or
advice if i were to do it?

-- 
Thien-Thi Nguyen
   GPG key: 4C807502
   (if you're human and you know it)
      read my lisp: (responsep (questions 'technical)
                               (not (via 'mailing-list)))
                     => nil

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

             reply	other threads:[~2014-05-14 18:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14 18:25 Thien-Thi Nguyen [this message]
2014-05-14 19:05 ` ELPA queue.el weirdness Stefan Monnier
2014-05-15  7:36   ` Thien-Thi Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lhu4tdz6.fsf@zigzag.favinet \
    --to=ttn@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=toby-predictive@dr-qubit.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.