From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: trunk r117128: Allow any non-nil value to count as true in bool-vector. Date: Tue, 20 May 2014 10:29:45 +0200 Message-ID: <87lhtwhmyu.fsf@gmx.de> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1400575950 9397 80.91.229.3 (20 May 2014 08:52:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 20 May 2014 08:52:30 +0000 (UTC) Cc: Dmitry Antipov , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 20 10:52:22 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WmfRS-00075J-JW for ged-emacs-devel@m.gmane.org; Tue, 20 May 2014 10:30:34 +0200 Original-Received: from localhost ([::1]:51857 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmfRS-0000M5-2l for ged-emacs-devel@m.gmane.org; Tue, 20 May 2014 04:30:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmfQt-00082p-Ao for emacs-devel@gnu.org; Tue, 20 May 2014 04:30:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmfQn-0003xV-DH for emacs-devel@gnu.org; Tue, 20 May 2014 04:29:59 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:65021) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmfQn-0003xC-42 for emacs-devel@gnu.org; Tue, 20 May 2014 04:29:53 -0400 Original-Received: from detlef.gmx.de ([93.209.94.209]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MWSwU-1WFD9z2PoA-00Xd6b; Tue, 20 May 2014 10:29:49 +0200 In-Reply-To: (Paul Eggert's message of "Mon, 19 May 2014 19:19:10 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-Provags-ID: V03:K0:SqikszI7YmuhwLl/19l23cNM30j8L+JSCHFZWwrGIbZ9UK+CXcd fBKMZIRXKkDu/Z49Q04mVxF+Cfm0M0MMGE7fXwZjZoDDfxQdaNczb72X8Tk6Q/nB9jBI+aB G0DEUo5/l/r0Kr1lBMO0t7cMXLnmhYqZeR8nQy4Z+uWABRyTQ+ysfLXOWpiTLn3omCjgHE+ +0vGEfjAW54JJ3qj13i9g== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 212.227.15.18 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:171944 Archived-At: Paul Eggert writes: > === modified file 'src/dbusbind.c' > --- a/src/dbusbind.c 2014-05-19 07:49:09 +0000 > +++ b/src/dbusbind.c 2014-05-19 19:19:05 +0000 > @@ -387,7 +387,8 @@ > break; > > case DBUS_TYPE_BOOLEAN: > - CHECK_BOOLEAN (object); > + /* Every Emacs Lisp object serves as a boolean, so there's nothing > + to check. */ > sprintf (signature, "%c", dtype); > break; > That's wrong. dbusbind.c maps Lisp types to D-Bus types, and it expects exactly t and nil as boolean values, nothing else. See also (info "(dbus)Type Conversion") I've reverted your patch (r117128) and the one from Dmitry (r117125). Best regards, Michael.