From: Michael Albinus <michael.albinus@gmx.de>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Dmitry Antipov <dmantipov@yandex.ru>, emacs-devel@gnu.org
Subject: Re: trunk r117128: Allow any non-nil value to count as true in bool-vector.
Date: Tue, 20 May 2014 10:29:45 +0200 [thread overview]
Message-ID: <87lhtwhmyu.fsf@gmx.de> (raw)
In-Reply-To: <E1WmT5a-0004kw-I2@vcs.savannah.gnu.org> (Paul Eggert's message of "Mon, 19 May 2014 19:19:10 +0000")
Paul Eggert <eggert@cs.ucla.edu> writes:
> === modified file 'src/dbusbind.c'
> --- a/src/dbusbind.c 2014-05-19 07:49:09 +0000
> +++ b/src/dbusbind.c 2014-05-19 19:19:05 +0000
> @@ -387,7 +387,8 @@
> break;
>
> case DBUS_TYPE_BOOLEAN:
> - CHECK_BOOLEAN (object);
> + /* Every Emacs Lisp object serves as a boolean, so there's nothing
> + to check. */
> sprintf (signature, "%c", dtype);
> break;
>
That's wrong. dbusbind.c maps Lisp types to D-Bus types, and it expects
exactly t and nil as boolean values, nothing else. See also
(info "(dbus)Type Conversion")
I've reverted your patch (r117128) and the one from Dmitry (r117125).
Best regards, Michael.
next parent reply other threads:[~2014-05-20 8:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1WmT5a-0004kw-I2@vcs.savannah.gnu.org>
2014-05-20 8:29 ` Michael Albinus [this message]
2014-05-20 14:33 ` trunk r117128: Allow any non-nil value to count as true in bool-vector Davis Herring
2014-05-20 19:09 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhtwhmyu.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=dmantipov@yandex.ru \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.