bug#18146: 24.3.92; hebrew tutorial says C-c is rebound.

bug#18146: 24.3.92; hebrew tutorial says C-c is rebound.

[Nicolas Richard]

Hi,

I reproduce the problem with:

emacs -Q -f winner-mode -f help-with-tutorial-spec-language

I hit "H e b <tab>" at the prompt to enter Hebrew tutorial.

I scroll down to line 590 which reads :
** C-c has been rebound, but you can use M-x mode-specific-command-prefix instead [More] **

If I click on "more" and then "more info" I get:
> Your Emacs customizations override the default binding for this key:

> The default Emacs binding for the key C-c is the command
> `mode-specific-command-prefix'.  However, your customizations have
> rebound it to the command `(keymap (keymap (right . winner-redo) (left
> . winner-undo)) mode-specific-command-prefix)'.

That does not happen in the english or french tutorial.

-- 
Nico

bug#18146: 24.3.92; hebrew tutorial says C-c is rebound.

[Eli Zaretskii]

> From: Nicolas Richard <theonewiththeevillook@yahoo.fr>
> Date: Tue, 29 Jul 2014 14:59:51 +0200
> 
> I reproduce the problem with:
> 
> emacs -Q -f winner-mode -f help-with-tutorial-spec-language
> 
> I hit "H e b <tab>" at the prompt to enter Hebrew tutorial.
> 
> I scroll down to line 590 which reads :
> ** C-c has been rebound, but you can use M-x mode-specific-command-prefix instead [More] **
> 
> If I click on "more" and then "more info" I get:
> > Your Emacs customizations override the default binding for this key:
> 
> > The default Emacs binding for the key C-c is the command
> > `mode-specific-command-prefix'.  However, your customizations have
> > rebound it to the command `(keymap (keymap (right . winner-redo) (left
> > . winner-undo)) mode-specific-command-prefix)'.
> 
> That does not happen in the english or french tutorial.

It happens for me with any tutorial, including English and French, in
the current emacs-24 branch.

The root cause is, obviously, in winner.el.

Not sure if this is worth fixing: newbies are not supposed to enable
winner-mode before reading the tutorial.

bug#18146: 24.3.92; hebrew tutorial says C-c is rebound.

[Eli Zaretskii]

> Date: Tue, 29 Jul 2014 16:05:41 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 18146@debbugs.gnu.org
> 
> > From: Nicolas Richard <theonewiththeevillook@yahoo.fr>
> > Date: Tue, 29 Jul 2014 14:59:51 +0200
> > 
> > I reproduce the problem with:
> > 
> > emacs -Q -f winner-mode -f help-with-tutorial-spec-language
> > 
> > I hit "H e b <tab>" at the prompt to enter Hebrew tutorial.
> > 
> > I scroll down to line 590 which reads :
> > ** C-c has been rebound, but you can use M-x mode-specific-command-prefix instead [More] **

Sorry, I failed to realize that you only talk about line 590.  I see
the red warning about rebound keys right at the beginning, and that
warning is shown in all tutorials.

But why should we care about only one of the warnings?  What is
special about line 590 when there's another warning about rebound keys
right at the beginning?

bug#18146: 24.3.92; hebrew tutorial says C-c is rebound.

[Eli Zaretskii]

> Date: Tue, 29 Jul 2014 16:16:23 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 18146@debbugs.gnu.org
> 
> > Date: Tue, 29 Jul 2014 16:05:41 +0300
> > From: Eli Zaretskii <eliz@gnu.org>
> > Cc: 18146@debbugs.gnu.org
> > 
> > > From: Nicolas Richard <theonewiththeevillook@yahoo.fr>
> > > Date: Tue, 29 Jul 2014 14:59:51 +0200
> > > 
> > > I reproduce the problem with:
> > > 
> > > emacs -Q -f winner-mode -f help-with-tutorial-spec-language
> > > 
> > > I hit "H e b <tab>" at the prompt to enter Hebrew tutorial.
> > > 
> > > I scroll down to line 590 which reads :
> > > ** C-c has been rebound, but you can use M-x mode-specific-command-prefix instead [More] **
> 
> Sorry, I failed to realize that you only talk about line 590.  I see
> the red warning about rebound keys right at the beginning, and that
> warning is shown in all tutorials.
> 
> But why should we care about only one of the warnings?  What is
> special about line 590 when there's another warning about rebound keys
> right at the beginning?

I fixed this anyway (r117416 on the emacs-24 branch).

Thanks.

bug#18146: 24.3.92; hebrew tutorial says C-c is rebound.

[Nicolas Richard]

Eli Zaretskii <eliz@gnu.org> writes:
> I fixed this anyway (r117416 on the emacs-24 branch).

That was quick !

Btw, perhaps we could also remove the bigger warning at the beginning by
not adding C-c to tutorial--default-keys ? Or is it there for a reason ?

-- 
Nico.

bug#18146: 24.3.92; hebrew tutorial says C-c is rebound.

[Eli Zaretskii]

> From: Nicolas Richard <theonewiththeevillook@yahoo.fr>
> Cc: theonewiththeevillook@yahoo.fr,  18146@debbugs.gnu.org
> Date: Tue, 29 Jul 2014 15:59:11 +0200
> 
> Btw, perhaps we could also remove the bigger warning at the beginning by
> not adding C-c to tutorial--default-keys ? Or is it there for a reason ?

I have no idea, sorry.

bug#18146: 24.3.92; hebrew tutorial says C-c is rebound.

[Glenn Morris]

Nicolas Richard wrote:

> Btw, perhaps we could also remove the bigger warning at the beginning by
> not adding C-c to tutorial--default-keys ? Or is it there for a reason ?

There was a comment in the source that got lost along the way:

   These [keys] are not mentioned but are basic:

I can't disagree with that, so I don't want to remove C-c from the list.