From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Shmakov Newsgroups: gmane.emacs.bugs Subject: bug#18246: enriched-encode: should set inhibit-point-motion-hooks, too Date: Mon, 11 Aug 2014 18:57:46 +0000 Message-ID: <87lhqurh05.fsf@violet.siamics.net> References: <87sil3qlc8.fsf@violet.siamics.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1407783564 16607 80.91.229.3 (11 Aug 2014 18:59:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 11 Aug 2014 18:59:24 +0000 (UTC) To: 18246@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 11 20:59:16 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XGuoN-0001QW-6p for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Aug 2014 20:59:15 +0200 Original-Received: from localhost ([::1]:37573 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGuoM-0008IZ-QB for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Aug 2014 14:59:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGuoF-0008HT-Gz for bug-gnu-emacs@gnu.org; Mon, 11 Aug 2014 14:59:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XGuoB-00025V-AX for bug-gnu-emacs@gnu.org; Mon, 11 Aug 2014 14:59:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGuoA-00025M-T1 for bug-gnu-emacs@gnu.org; Mon, 11 Aug 2014 14:59:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XGuoA-0004CD-Eg for bug-gnu-emacs@gnu.org; Mon, 11 Aug 2014 14:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Aug 2014 18:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18246 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18246-submit@debbugs.gnu.org id=B18246.140778350316077 (code B ref 18246); Mon, 11 Aug 2014 18:59:02 +0000 Original-Received: (at 18246) by debbugs.gnu.org; 11 Aug 2014 18:58:23 +0000 Original-Received: from localhost ([127.0.0.1]:39691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGunW-0004BC-6i for submit@debbugs.gnu.org; Mon, 11 Aug 2014 14:58:22 -0400 Original-Received: from fely.am-1.org ([78.47.74.50]:50209) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGun9-0004AG-5V for 18246@debbugs.gnu.org; Mon, 11 Aug 2014 14:58:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=Lax/pma49KMppWrSVwSTrg9353+5j7Yz1+v427q8rZM=; b=hFdcBLkQ/jQtFrA8H0CKmfWfxHwiymEer5n+41JkToaziquAd4NW73E8EOCnwk2Idu6et5/681pKni+CmcHwsP+DiTzrxk8vzVB5PZyHOWvYI0Cnt+GzcCun4KzEvBtSOCj2VIxwOpqLhf0b0dO6uGJUIYulp8Yq6QmPFKSB5xU=; Original-Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XGun4-000401-AN for 18246@debbugs.gnu.org; Mon, 11 Aug 2014 18:57:54 +0000 Original-Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XGumx-00030P-7N for 18246@debbugs.gnu.org; Tue, 12 Aug 2014 01:57:47 +0700 In-Reply-To: (Stefan Monnier's message of "Mon, 11 Aug 2014 10:47:24 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92423 Archived-At: >>>>> Stefan Monnier writes: >> the encoded part, it doesn=E2=80=99t yet set inhibit-point-motion-hooks, >> which easily results in incorrect encoding should text being encoded >> contain parts protected with the =E2=80=98intangible=E2=80=99 property. > `intangible' is evil, nasty, and sucks rocks. Your patch is probably > OK, but even better would be to fix the code that uses `intangible'. > So, do you happen to know why there was a `intangible' in the way? Of the packages I use, ERC and Gnus make use of =E2=80=98intangible=E2=80= =99 by default. Specifically, the default for erc-timestamp-intangible is =E2=80=98t=E2=80=99, and for gnus-hidden-properties it=E2=80=99s =E2=80= =98invisible t intangible t=E2=80=99 =E2=80=93 which, per (elisp.info) Special Properties, is also unnecessary: [=E2=80=A6] A common misuse is to put an intangible property on invisib= le text, which is actually unnecessary since the command loop will move point outside of the invisible text at the end of each command anyway. [=E2=80=A6] Gnus, however, appears to use overlays extensively for highlighting, while overlays, in turn, seem to be completely ignored by enriched.el, thus making enriched-encode unlikely to cause issues when called over Gnus buffers. It seems that the property is also used by RefTeX and SES, but I haven=E2=80=99t found any use to either yet. $ grep -irE --include=3D\*.el -- "put-text-property\\s.*'intangible" lisp lisp/erc/erc-stamp.el: (erc-put-text-property from (1+ (point)) 'intangible= t))))) lisp/erc/erc-stamp.el: (erc-put-text-property 0 (length ts) 'intangibl= e t ts)) lisp/textmodes/reftex-toc.el: (put-text-property (point-min) (point) '= intangible t) lisp/textmodes/reftex-index.el: (put-text-property 1 (point) 'intangib= le t) lisp/ses.el: (put-text-property startpos (point) 'intangible lisp/ses.el: (put-text-property pos end 'intangible sym))) lisp/ses.el: (put-text-property pos end 'intangible new-name)) lisp/gnus/gnus-uu.el: (put-text-property (point-min) (point-max) 'int= angible nil)) $=20 --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A