From: Ivan Shmakov <ivan@siamics.net>
To: 18246@debbugs.gnu.org
Subject: bug#18246: enriched-encode: should set inhibit-point-motion-hooks, too
Date: Mon, 11 Aug 2014 18:57:46 +0000 [thread overview]
Message-ID: <87lhqurh05.fsf@violet.siamics.net> (raw)
In-Reply-To: <jwva97bt77t.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Mon, 11 Aug 2014 10:47:24 -0400")
>>>>> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> the encoded part, it doesn’t yet set inhibit-point-motion-hooks,
>> which easily results in incorrect encoding should text being encoded
>> contain parts protected with the ‘intangible’ property.
> `intangible' is evil, nasty, and sucks rocks. Your patch is probably
> OK, but even better would be to fix the code that uses `intangible'.
> So, do you happen to know why there was a `intangible' in the way?
Of the packages I use, ERC and Gnus make use of ‘intangible’ by
default. Specifically, the default for erc-timestamp-intangible
is ‘t’, and for gnus-hidden-properties it’s ‘invisible t
intangible t’ – which, per (elisp.info) Special Properties,
is also unnecessary:
[…] A common misuse is to put an intangible property on invisible
text, which is actually unnecessary since the command loop will move
point outside of the invisible text at the end of each command
anyway. […]
Gnus, however, appears to use overlays extensively for
highlighting, while overlays, in turn, seem to be completely
ignored by enriched.el, thus making enriched-encode unlikely to
cause issues when called over Gnus buffers.
It seems that the property is also used by RefTeX and SES, but I
haven’t found any use to either yet.
$ grep -irE --include=\*.el -- "put-text-property\\s.*'intangible" lisp
lisp/erc/erc-stamp.el: (erc-put-text-property from (1+ (point)) 'intangible t)))))
lisp/erc/erc-stamp.el: (erc-put-text-property 0 (length ts) 'intangible t ts))
lisp/textmodes/reftex-toc.el: (put-text-property (point-min) (point) 'intangible t)
lisp/textmodes/reftex-index.el: (put-text-property 1 (point) 'intangible t)
lisp/ses.el: (put-text-property startpos (point) 'intangible
lisp/ses.el: (put-text-property pos end 'intangible sym)))
lisp/ses.el: (put-text-property pos end 'intangible new-name))
lisp/gnus/gnus-uu.el: (put-text-property (point-min) (point-max) 'intangible nil))
$
--
FSF associate member #7257 http://boycottsystemd.org/ … 3013 B6A0 230E 334A
next prev parent reply other threads:[~2014-08-11 18:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 12:09 bug#18246: enriched-encode: should set inhibit-point-motion-hooks, too Ivan Shmakov
2014-08-11 14:47 ` Stefan Monnier
2014-08-11 18:57 ` Ivan Shmakov [this message]
2014-08-12 3:15 ` Richard Stallman
2014-08-12 14:38 ` Eli Zaretskii
2014-08-13 3:59 ` Richard Stallman
2014-08-13 15:08 ` Eli Zaretskii
2014-08-13 22:50 ` Richard Stallman
2014-08-14 18:14 ` Ivan Shmakov
2014-08-14 18:26 ` Eli Zaretskii
2014-08-14 19:25 ` Stefan Monnier
2014-08-12 14:53 ` Stefan Monnier
2015-02-14 8:31 ` Ivan Shmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhqurh05.fsf@violet.siamics.net \
--to=ivan@siamics.net \
--cc=18246@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.