From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Shmakov Newsgroups: gmane.emacs.bugs Subject: bug#19253: M-x eww (G): does not add a eww-history entry Date: Tue, 02 Dec 2014 15:15:49 +0000 Message-ID: <87lhmqozfe.fsf@violet.siamics.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1417533446 11509 80.91.229.3 (2 Dec 2014 15:17:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 2 Dec 2014 15:17:26 +0000 (UTC) To: 19253@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 02 16:17:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XvpCa-0001ic-GA for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Dec 2014 16:17:20 +0100 Original-Received: from localhost ([::1]:37355 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvpCZ-00034r-Vw for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Dec 2014 10:17:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvpCR-000310-Lq for bug-gnu-emacs@gnu.org; Tue, 02 Dec 2014 10:17:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XvpCJ-0006vi-U5 for bug-gnu-emacs@gnu.org; Tue, 02 Dec 2014 10:17:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvpCI-0006vK-Oh for bug-gnu-emacs@gnu.org; Tue, 02 Dec 2014 10:17:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XvpCI-0004GS-6q for bug-gnu-emacs@gnu.org; Tue, 02 Dec 2014 10:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Dec 2014 15:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19253 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: submit@debbugs.gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.141753336616317 (code B ref -1); Tue, 02 Dec 2014 15:17:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Dec 2014 15:16:06 +0000 Original-Received: from localhost ([127.0.0.1]:51896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvpBN-0004F6-Nw for submit@debbugs.gnu.org; Tue, 02 Dec 2014 10:16:06 -0500 Original-Received: from fely.am-1.org ([78.47.74.50]:43212) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvpBK-0004EZ-5U for submit@debbugs.gnu.org; Tue, 02 Dec 2014 10:16:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=F9I8vyQ+EHx9IKspIDsv4bE6aR1kjorMtGAmVO409bw=; b=YrdIcNbQqz6do9f/1xAgM8OX/VK2O4cnndB2P9UgMi4hWHoes+eDZL93UZqfhw58LzPb6dE6b3vkIY+CqDIx7ix/2UOiwb3xQ+AKhmX7qEvq1MbKO4oWd/GKRuf1TzLrucBU6NA1I37a4t/bXJn+rvojzppNvyBfe8oa5KfNv7g=; Original-Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XvpBH-00070V-Nf for submit@debbugs.gnu.org; Tue, 02 Dec 2014 15:16:00 +0000 Original-Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XvpB9-0006SC-CH for submit@debbugs.gnu.org; Tue, 02 Dec 2014 22:15:51 +0700 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96804 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Package: emacs Severity: minor Using eww.el as of 52fab40c1606 (2014-12-01 17:56:02Z), the following sequence results in the =E2=80=9CNo eww-histories are defined=E2= =80=9D error. And indeed, eww-history at this point is nil. $ emacs -Q=20 M-x eww RET https://example.org/ RET G https://example.net/ RET H Please consider the (first) patch MIMEd. * net/eww.el (eww): Moved history recording here... (eww-browse-url): ... from here. One another suggestion is to use generate-new-buffer in eww-browse-url, as per the second patch MIMEd. * net/eww.el (eww-browse-url): Use generate-new-buffer (was: iterating over possible buffer names.) --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/net/eww.el 2014-12-01 17:56:02 +0000 +++ b/lisp/net/eww.el 2014-12-02 14:59:54 +0000 @@ -253,7 +253,10 @@ defun eww (url &optional no-save-history) (setq url (concat url "/")))) (setq url (concat eww-search-prefix (replace-regexp-in-string " " "+" url)))))) - (unless (eq major-mode 'eww-mode) + (if (eq major-mode 'eww-mode) + (when (or (plist-get eww-data :url) + (plist-get eww-data :dom)) + (eww-save-history)) (eww-setup-buffer) (plist-put eww-data :url url) (eww-update-header-line-format) @@ -685,10 +688,7 @@ defun eww-browse-url (url &optional new-window) (setq num (1+ num) new-buffer (format "*eww*<%d>" num))) (switch-to-buffer new-buffer)) - (eww-mode)) - ((and (equal major-mode 'eww-mode) - (plist-get eww-data :url)) - (eww-save-history))) + (eww-mode))) (eww url)) (defun eww-back-url () --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/net/eww.el 2014-12-02 14:59:54 +0000 +++ b/lisp/net/eww.el 2014-12-02 15:02:33 +0000 @@ -682,12 +682,7 @@ ;;;###autoload (defun eww-browse-url (url &optional new-window) (cond (new-window - (let ((new-buffer "*eww*") - (num 0)) - (while (get-buffer new-buffer) - (setq num (1+ num) - new-buffer (format "*eww*<%d>" num))) - (switch-to-buffer new-buffer)) + (switch-to-buffer (generate-new-buffer "*eww*")) (eww-mode))) (eww url)) --=-=-=--