From: Tassilo Horn <tsdh@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 19645-done@debbugs.gnu.org
Subject: bug#19645: 25.0.50; Recent EIEIO changes broke helm: Lisp error: (cl-no-next-method helm--setup-source...
Date: Thu, 22 Jan 2015 08:00:30 +0100 [thread overview]
Message-ID: <87lhkvz4dt.fsf@gnu.org> (raw)
In-Reply-To: <jwvtwzkazy9.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Wed, 21 Jan 2015 11:03:34 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> helm-bbdb.el:22:1:Error: No next method for %S: helm--setup-source,
>> nil, [eieio-class-tag--helm-type-file...
>
> It appears that you're calling helm--setup-source with an object of
> type helm-type-file, but the only method that matches is a ":before"
> method, so after running the before method, you get an error because
> there's no primary.
>
> IIUC the error should be `cl-no-primary-method' instead of
> `cl-no-next-method' (according to
> http://www.cliki.net/Proposed%20ANSI%20Revisions%20and%20Clarifications).
>
> From what I can tell, the older EIEIO code just silently did nothing
> in this case, treating the missing primary as a function that just
> returns nil, but I think this is a mistake.
>
> I'm not sure how to preserve the compatibility with this mistake.
> I'll see if I can come up with something, but in any case I think you
> should fix Helm by making sure there is some primary method defined in
> this case as well.
No if it's a usage error on the helm side which the older EIEIO simply
ignored, then I'd suggest not to reinstall compatibility with that older
version but with CLOS, i.e., signal `cl-no-primary-method' instead of
`cl-no-next-method'.
Oh, and I see that Thierry (the helm dev) already added primary methods
in
https://github.com/emacs-helm/helm/commit/1eb07354f50ec26aa8be1290233696656b8dca32
So I'm closing this bug.
Bye,
Tassilo
next prev parent reply other threads:[~2015-01-22 7:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 7:18 bug#19645: 25.0.50; Recent EIEIO changes broke helm: Lisp error: (cl-no-next-method helm--setup-source Tassilo Horn
2015-01-21 16:03 ` Stefan Monnier
2015-01-21 16:38 ` Thierry Volpiatto
2015-01-21 17:36 ` Thierry Volpiatto
2015-01-21 19:51 ` Stefan Monnier
2015-01-21 19:49 ` Stefan Monnier
2015-01-21 20:58 ` Thierry Volpiatto
2015-01-21 21:53 ` Stefan Monnier
2015-01-22 4:17 ` Stefan Monnier
2015-01-22 7:00 ` Tassilo Horn [this message]
2015-01-22 17:08 ` Stefan Monnier
2015-01-23 7:08 ` Thierry Volpiatto
2015-01-23 20:56 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhkvz4dt.fsf@gnu.org \
--to=tsdh@gnu.org \
--cc=19645-done@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.