From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 8c909d7: * src/gfilenotify.c (Fgfile_add_watch): Decrease polling rate. Date: Thu, 24 Sep 2015 22:52:02 +0200 Message-ID: <87lhbvo80d.fsf@gmx.de> References: <20150924073633.16471.60525@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1443127957 13320 80.91.229.3 (24 Sep 2015 20:52:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Sep 2015 20:52:37 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 24 22:52:28 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZfDVC-0002Gr-Ki for ged-emacs-devel@m.gmane.org; Thu, 24 Sep 2015 22:52:26 +0200 Original-Received: from localhost ([::1]:33001 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfDVC-0006v8-6S for ged-emacs-devel@m.gmane.org; Thu, 24 Sep 2015 16:52:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfDUx-0006tC-Qs for emacs-devel@gnu.org; Thu, 24 Sep 2015 16:52:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfDUu-0003u0-Iq for emacs-devel@gnu.org; Thu, 24 Sep 2015 16:52:11 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:59727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfDUu-0003sy-DH for emacs-devel@gnu.org; Thu, 24 Sep 2015 16:52:08 -0400 Original-Received: from detlef.gmx.de ([87.146.42.203]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MHH3P-1ZtDqS3IfL-00E24P; Thu, 24 Sep 2015 22:52:03 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 24 Sep 2015 08:26:00 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:xo8m/lNWkkTIUIPZ1VS1YCbWOYRwGk/VpDjNG3Bp1jpKIfu7jF1 K7S+PvsvLKubKILcZdIsX9vNDswv8GrpJtn4K/Nr7c13Bn8vhVX/WaRirBzpDxI0Y+Z4Fxu 0+/yNyEsgLTQkdXePrxOQcezrEDWQ9jXyfKwVz0FiES90RV3eUYDL6GDSvJbHCnW3gLN9Hi KilTgNbQPKbaH+mT+3YqQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:y6Wm1N61Y1U=:HYBQ8OzUTTGq8RX+d01ccT qwi6hcHCVkyxLbtkuEJydmcxuZht4TjFFgOyKE/ZYyxEC9feKkBsibnidTRB7hdzk569M1gq8 Wvc/VXmhD/YxlSlcCftPW4b+N6G5cRiVm/BQ2sxF4pyKVYqU0JbBE+SGr2kn6zUKiulShRLx/ Iejl94oL6DopxSrDOflHUKmC+Ls/iXh5kcMHsSZzEjEYuCXUwXy8FbkVSq810n7t1SPdTcfn2 7QDVUngykmFgzPYKOjz5uEg+fW9WyShEODAu8Jnso84IMk2xVbeDuBe9vVXdxcfyjS6LmgIZ+ 1F6/nkoY/iyq0kzOHvLWV1SBjScZQarIqTCRCZYnktx0ZLt62p2Ar4wjmOfQ6FMsnUJRgq2Qu Qrv9SZmNjv+T7/UDqPt3BZH245vYV2U6MB+NSNb+DhQkAdeVppNniXW/xpCPm76VKk3nh/IY0 w7gwyeFJTyMErXPyDOoU3+kFMegZWYlfhwK5r2dRGEQWBLEt654BIs5X+SrLUUrdPM5uw1Gvt Ha2BAN/fTFPpeYmecDrocegeCoPZ3Y+i4Y72RSr8H1zj5psleuhYYHHUjKhw1Dk58O4dBbfKm W5Cj+6nzEltSSArtcoR426zlD/rZPY4rfedScKPJZ2zrsbMF/E5NSycoOVOmCv3iPW31FFTWW yCauaXNOV3bk2sIy+DfT343aisUNKjKvbjIQu4MA9gIyB/J3/2obPvZw00+WDSQIeP9I7ijdK 2QRufE/i7eWJYd1DmT9A1Mt8Nx4C9wq0URMjLQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:190337 Archived-At: Stefan Monnier writes: >> * src/gfilenotify.c (Fgfile_add_watch): Decrease polling rate. > > Decreasing the rate means increasing the interval. From the "800 msec" > comment I get the impression that the patch reduces the interval, and > hence increases the rate. > > Which one is it? And why do we need/want to do that (i.e. could you > add a comment pointing the to a discussion or something)? It is the polling rate gio (glib) checks for changes of a file, once it has been set up to be monitored, and there is no native library like inotify or kqueue which send a changed event w/o need to poll. See I've changed this, because typically users of filemonitor.el use (read-event nil nil 0.1) when they are waiting for a file notification event. I don't believe it will be a performance issue, because most of the uses Emacs is based on non-polling file notifications. Either inotify or w32notify directly, of gfilenotify with built-in inotify or kqueue. Maybe it's worth to make it configurable? Don't know. > Stefan Best regards, Michael.