From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: UP and DOWN with multi-line minibuffer history Date: Mon, 14 Dec 2015 17:41:21 +0100 Message-ID: <87lh8x7zke.fsf@fencepost.gnu.org> References: <83wpsj6978.fsf@gnu.org> <87y4czz63l.fsf@mail.linkov.net> <83lh8y5q3k.fsf@gnu.org> <8761019ybj.fsf@fencepost.gnu.org> <838u4x3tr9.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1450111319 23101 80.91.229.3 (14 Dec 2015 16:41:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 14 Dec 2015 16:41:59 +0000 (UTC) Cc: emacs-devel@gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 14 17:41:58 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a8WCB-0001pn-Hk for ged-emacs-devel@m.gmane.org; Mon, 14 Dec 2015 17:41:55 +0100 Original-Received: from localhost ([::1]:60883 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8WCB-0004DI-2G for ged-emacs-devel@m.gmane.org; Mon, 14 Dec 2015 11:41:55 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8WBs-0004Cx-VG for emacs-devel@gnu.org; Mon, 14 Dec 2015 11:41:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8WBs-0007Aj-3N for emacs-devel@gnu.org; Mon, 14 Dec 2015 11:41:36 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34537) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8WBs-0007Af-0W; Mon, 14 Dec 2015 11:41:36 -0500 Original-Received: from localhost ([127.0.0.1]:48355 helo=lola) by fencepost.gnu.org with esmtp (Exim 4.82) (envelope-from ) id 1a8WBq-00069P-VF; Mon, 14 Dec 2015 11:41:35 -0500 Original-Received: by lola (Postfix, from userid 1000) id 7DF20DF4F0; Mon, 14 Dec 2015 17:41:21 +0100 (CET) In-Reply-To: <838u4x3tr9.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 14 Dec 2015 18:00:26 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196246 Archived-At: Eli Zaretskii writes: >> From: David Kastrup >> Cc: Juri Linkov , emacs-devel@gnu.org >> Date: Mon, 14 Dec 2015 10:25:20 +0100 >> >> >From simple.el: >> >> (defun line-move (arg &optional noerror to-end try-vscroll) >> "Move forward ARG lines. >> If NOERROR, don't signal an error if we can't move ARG lines. >> TO-END is unused. >> TRY-VSCROLL controls whether to vscroll tall lines: if either >> `auto-window-vscroll' or TRY-VSCROLL is nil, this function will >> not vscroll." >> [...] >> (if (and line-move-visual >> ;; Display-based column are incompatible with goal-column. >> (not goal-column) >> > > I said "in the visual-line sense", and I meant it. You are looking at > the wrong part of the code; you should instead look at how > line-move-visual calls vertical-motion passing it the value of > temporary-goal-column. I don't quite see why I should look at `line-move-visual' when `line-move-visual' is never called by `line-move' when `goal-column' is set and there is no other caller of `line-move-visual' in the Emacs code base. -- David Kastrup