all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: David Kastrup <dak@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, juri@linkov.net
Subject: Re: UP and DOWN with multi-line minibuffer history
Date: Mon, 14 Dec 2015 17:41:21 +0100	[thread overview]
Message-ID: <87lh8x7zke.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <838u4x3tr9.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 14 Dec 2015 18:00:26 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: David Kastrup <dak@gnu.org>
>> Cc: Juri Linkov <juri@linkov.net>,  emacs-devel@gnu.org
>> Date: Mon, 14 Dec 2015 10:25:20 +0100
>>
>> >From simple.el:
>> 
>> (defun line-move (arg &optional noerror to-end try-vscroll)
>>   "Move forward ARG lines.
>> If NOERROR, don't signal an error if we can't move ARG lines.
>> TO-END is unused.
>> TRY-VSCROLL controls whether to vscroll tall lines: if either
>> `auto-window-vscroll' or TRY-VSCROLL is nil, this function will
>> not vscroll."
>> [...]
>>       (if (and line-move-visual
>>                ;; Display-based column are incompatible with goal-column.
>>                (not goal-column)
>> 
>
> I said "in the visual-line sense", and I meant it.  You are looking at
> the wrong part of the code; you should instead look at how
> line-move-visual calls vertical-motion passing it the value of
> temporary-goal-column.

I don't quite see why I should look at `line-move-visual' when
`line-move-visual' is never called by `line-move' when `goal-column' is
set and there is no other caller of `line-move-visual' in the Emacs code
base.

-- 
David Kastrup



  reply	other threads:[~2015-12-14 16:41 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-12 14:19 UP and DOWN with multi-line minibuffer history Eli Zaretskii
2015-12-12 15:03 ` Dmitry Gutov
2015-12-12 23:04   ` John Wiegley
2015-12-12 22:47 ` Eric Hanchrow
2015-12-12 23:20 ` Juri Linkov
2015-12-13 15:24   ` Eli Zaretskii
2015-12-14  0:07     ` Juri Linkov
2015-12-14  3:39       ` Eli Zaretskii
2015-12-14 23:45         ` Juri Linkov
2015-12-15  3:37           ` Eli Zaretskii
2015-12-16  0:32             ` Juri Linkov
2015-12-16  1:33               ` Dmitry Gutov
2015-12-17  0:45                 ` Juri Linkov
2015-12-16  2:02               ` Yuri Khan
2015-12-16  6:29                 ` Drew Adams
2015-12-17  0:49                 ` Juri Linkov
2015-12-15  3:43         ` Dmitry Gutov
2015-12-15 15:45           ` Eli Zaretskii
2015-12-14  9:25     ` David Kastrup
2015-12-14 16:00       ` Eli Zaretskii
2015-12-14 16:41         ` David Kastrup [this message]
2015-12-14 17:03           ` Eli Zaretskii
     [not found] <CABr8ebZDmnsCKyBnzU3sSDHefJ2_3uC4Omwg=N4qQ8h80vTxpw@mail.gmail.com>
2015-12-13  3:31 ` Eli Zaretskii
2015-12-13  5:38   ` Anders Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lh8x7zke.fsf@fencepost.gnu.org \
    --to=dak@gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.