From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Oleh Krehel Newsgroups: gmane.emacs.devel Subject: Re: Can we not introduce frivolous indentation change to define-minor-mode? Date: Wed, 06 Jan 2016 13:38:02 +0100 Message-ID: <87lh82vq6t.fsf@gmail.com> References: <83d1tg57p6.fsf@gnu.org> <87fuybqdby.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1452083914 8769 80.91.229.3 (6 Jan 2016 12:38:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Jan 2016 12:38:34 +0000 (UTC) Cc: emacs-devel@gnu.org To: Leo Liu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 06 13:38:20 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aGnM2-0006uy-5T for ged-emacs-devel@m.gmane.org; Wed, 06 Jan 2016 13:38:18 +0100 Original-Received: from localhost ([::1]:53940 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGnLw-00043t-9r for ged-emacs-devel@m.gmane.org; Wed, 06 Jan 2016 07:38:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGnLs-00041j-PM for emacs-devel@gnu.org; Wed, 06 Jan 2016 07:38:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGnLo-0007yT-OF for emacs-devel@gnu.org; Wed, 06 Jan 2016 07:38:08 -0500 Original-Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:33947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGnLo-0007yN-IR for emacs-devel@gnu.org; Wed, 06 Jan 2016 07:38:04 -0500 Original-Received: by mail-wm0-x234.google.com with SMTP id u188so58600367wmu.1 for ; Wed, 06 Jan 2016 04:38:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=JTJovT9Vw+XCqQeVZE3NdbTU7p5hnIMG0lNn2aSYYDw=; b=X/wJKmCjFaPDL9vyL4+ur62QyYoj0FlTgYnvR9MfIyHdHWdTmFeQW/hvfmxgEau06v JtwGZ6gKICdmvPNzF4QFF9CAgz8Az3N8E1CzeNVW8af6aKUQ0i5aAMpahIdIwGgIrArq 3SLyhKmqDXMr1z2EKvBhcZOfSyYKlS80oOIPoaqkuWkBhwp0f9/pu/KWI80BaRyf7Fav Zu1w56IMWDEuh4L8hjaAEYdhHki9t8uRscvR35ZqJULcZHBYrYQ0LL9ppHIMcjJJi5o5 1s64F3ZzWW3ly9Xsi7Qcey+TOXb3YQlWv0BKgaRfwK68bTLBwfY0qAjFDITvOo2Ij93/ oeHA== X-Received: by 10.194.158.73 with SMTP id ws9mr120887021wjb.40.1452083884028; Wed, 06 Jan 2016 04:38:04 -0800 (PST) Original-Received: from firefly ([91.219.111.102]) by smtp.gmail.com with ESMTPSA id n129sm8540691wmb.1.2016.01.06.04.38.03 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 06 Jan 2016 04:38:03 -0800 (PST) In-Reply-To: (Leo Liu's message of "Wed, 06 Jan 2016 19:50:33 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:197695 Archived-At: Leo Liu writes: > Secondly those forms already indent correctly without introducing > (indent 1) Not true. Here's the indentation without an indent spec: (define-minor-mode ace-window-display-mode "Minor mode for showing the ace window key in the mode line." :global t) Here's the correct indentation with (indent 1) spec: (define-minor-mode ace-window-display-mode "Minor mode for showing the ace window key in the mode line." :global t) This applies when (setq lisp-indent-function 'common-lisp-indent-function) is used. > I'd like to revert the change to keep the behaviour > consistent with previous emacsen. WDYT? I'm against the revert. I'd like to keep using `common-lisp-indent-function' without extra configuration.