all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Oleh Krehel <ohwoeowho@gmail.com>
To: Leo Liu <sdl.web@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Can we not introduce frivolous indentation change to define-minor-mode?
Date: Wed, 06 Jan 2016 13:38:02 +0100	[thread overview]
Message-ID: <87lh82vq6t.fsf@gmail.com> (raw)
In-Reply-To: <m1fuybhqpi.fsf@zeuss-MBP.lan> (Leo Liu's message of "Wed, 06 Jan 2016 19:50:33 +0800")

Leo Liu <sdl.web@gmail.com> writes:

> Secondly those forms already indent correctly without introducing
> (indent 1)

Not true. Here's the indentation without an indent spec:

(define-minor-mode ace-window-display-mode
    "Minor mode for showing the ace window key in the mode line."
  :global t)

Here's the correct indentation with (indent 1) spec:

(define-minor-mode ace-window-display-mode
  "Minor mode for showing the ace window key in the mode line."
  :global t)

This applies when (setq lisp-indent-function 'common-lisp-indent-function)
is used.

> I'd like to revert the change to keep the behaviour
> consistent with previous emacsen. WDYT?

I'm against the revert. I'd like to keep using
`common-lisp-indent-function' without extra configuration.



  reply	other threads:[~2016-01-06 12:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-05 12:32 Can we not introduce frivolous indentation change to define-minor-mode? Leo Liu
2016-01-05 16:09 ` Eli Zaretskii
2016-01-05 23:11   ` Leo Liu
2016-01-06  9:14     ` Oleh Krehel
2016-01-06 11:50       ` Leo Liu
2016-01-06 12:38         ` Oleh Krehel [this message]
2016-01-06 13:42           ` Artur Malabarba
2016-01-06 13:56             ` Oleh Krehel
2016-01-06 14:33               ` Artur Malabarba
2016-01-06 15:37               ` Jonas Bernoulli
2016-01-06 15:48                 ` Oleh Krehel
2016-01-06 15:54                   ` Dmitry Gutov
2016-01-06 16:02                     ` Oleh Krehel
2016-01-07  1:54                       ` Leo Liu
2016-01-07 16:09                         ` Eli Zaretskii
2016-01-07 17:58                           ` John Wiegley
2016-01-07 18:49                             ` Leo Liu
2016-01-07 19:00                               ` John Wiegley
2016-01-07 19:40                                 ` Leo Liu
2016-01-07 19:05                               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lh82vq6t.fsf@gmail.com \
    --to=ohwoeowho@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.