From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 f5c762c: Additional changes for "make check-expensive" Date: Tue, 12 Jan 2016 20:03:42 +0100 Message-ID: <87lh7uwrg1.fsf@gmx.de> References: <20160105084751.30334.99051@vcs.savannah.gnu.org> <87io2y66dl.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1452625924 24780 80.91.229.3 (12 Jan 2016 19:12:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Jan 2016 19:12:04 +0000 (UTC) Cc: emacs-devel@gnu.org To: phillip.lord@russet.org.uk (Phillip Lord) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 12 20:11:55 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aJ4MB-0004Uh-3G for ged-emacs-devel@m.gmane.org; Tue, 12 Jan 2016 20:11:51 +0100 Original-Received: from localhost ([::1]:33835 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJ4MA-0001Tp-7p for ged-emacs-devel@m.gmane.org; Tue, 12 Jan 2016 14:11:50 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJ4EO-0006Su-FS for emacs-devel@gnu.org; Tue, 12 Jan 2016 14:03:49 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJ4EL-000595-8n for emacs-devel@gnu.org; Tue, 12 Jan 2016 14:03:48 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:49903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJ4EK-000590-Vq for emacs-devel@gnu.org; Tue, 12 Jan 2016 14:03:45 -0500 Original-Received: from detlef.gmx.de ([87.146.58.225]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0LskKv-1aCHzS3HiL-012LIh; Tue, 12 Jan 2016 20:03:43 +0100 In-Reply-To: <87io2y66dl.fsf@russet.org.uk> (Phillip Lord's message of "Tue, 12 Jan 2016 17:43:18 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:fnAzxbC/+OYh2cv6hYPWPSw3oX7H4Yb9PP/Oj7t9ObPakV0kgIn tn0TMLnqxd17iY5SKZJOih1ZeDv9KaFwqDn2F0jUdnFqrghIwPkaIlNuUPmPqDL73QyTgqt csnkWTSOIjLQNRQfFV13Yx6t2dZeos4EMIBhrt7KEeawYk7b9AnfctRj12I/gxvllkdfnlu UNW94vzFL6Z+tTpWfMyYA== X-UI-Out-Filterresults: notjunk:1;V01:K0:wwjlN+vglDQ=:6Uv/x+XCz7kr4Cb+6+0UG8 6trqNE0qIBk1bT+nAgx6k2hgH+HzE1q9IFW6PjwqvhhsGzKF+rCrvyJ06GbngfBP1Q8wImeJn Ge6C0mrClBcg2VEPCvBLdlU5l/zDhEwUNCB+b2xfF2Pey0fzW59rHPLDJIaelFPex45/VY2zi jT2NK1jf5CCkrlbQKe5nuqB94qiB9Kh2wpeE+muivgGkDeGaj3iGPkIKKozHCRyyFkEa+LUzj ph3r/ylXdhNvTwRCpe43MwUTQnTeAL2e2AbvLj42+qk1e5Jk22excLfTt7YKjD4PrrfuR3nTg aM0cUpfMXSbStJ93TJFX+dNGd2pR5qqXio7DScQFxMxvbOT15ZiKPTI8pUWvGnj807Ni6Hmcw UkzkhvlPaULqHhIV0uuLyeHd5Fl0l6YHEwxLqpSg36yxJ5FE4D20V+QxN2epSn+CY1p0Z2H+x 1oC4tFTorJkRsxTzRon2sJUzKnplEb0m25SHCfCH/oVdaRTLFrBN3p5raM2aiFUZh98PTaYNV WkV/vWWraGjetgOL121ZgbxZQkTRkv8ChClh3UWis+N8KtCPUvgcgvzB/PqqXFi+PbVaJcgm9 XWgZqcNPDXO4dWgMvsk9yG/58y+W46jmiUxzAcBWzflePaJzKPqHu0gMaPB6fAQUKEod6jvza 1qZSBSTpBn6e81ZNTR6IFbiCJncqSAioHw9NH+iZqx1l2pz958+9InhseyfNFehQ0SRmogYX3 Snrk4GMwXD26zy5fkM/kWAB1rkDFTX7koYgHWpoVSLdWDY2X2vkfuhQzeHRc842JDJ7S6XP6 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.18 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:198099 Archived-At: phillip.lord@russet.org.uk (Phillip Lord) writes: > Michael Hi Philip, > I think that there is a problem with this commit, in that the default > selector is only used for "make check". By default "make check-maybe" > runs all tests (including the expensive ones). So, you have to do > > make check-maybe SELECTOR="(quote (not (tag :expensive-test)))" > > I think it makes more sense for check-maybe to skip expensive tests, > unless told otherwise, as "make check-maybe" is a good candidate for use > pre-commit. I see. Before touching the Makefile, we shall agree how all the targets shall behave. I would say, that "check" and "check-maybe" shall skip the expensive tests. "check-expensive", "", and ".log" shall run all tests. > Phil Best regards, Michael.