From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: arbitools Date: Sun, 21 Feb 2016 19:58:15 +0100 Message-ID: <87lh6d99h4.fsf@bernoul.li> References: <1806012502.7608447.1456049133392.JavaMail.yahoo.ref@mail.yahoo.com> <1806012502.7608447.1456049133392.JavaMail.yahoo@mail.yahoo.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456081132 6915 80.91.229.3 (21 Feb 2016 18:58:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 21 Feb 2016 18:58:52 +0000 (UTC) Cc: "emacs-devel@gnu.org" To: David Gonzalez Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 21 19:58:43 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aXZDL-00070N-4p for ged-emacs-devel@m.gmane.org; Sun, 21 Feb 2016 19:58:39 +0100 Original-Received: from localhost ([::1]:43362 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXZDK-0002X4-AB for ged-emacs-devel@m.gmane.org; Sun, 21 Feb 2016 13:58:38 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXZD5-0002Wb-3B for emacs-devel@gnu.org; Sun, 21 Feb 2016 13:58:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXZD1-00061d-Sp for emacs-devel@gnu.org; Sun, 21 Feb 2016 13:58:23 -0500 Original-Received: from mail.hostpark.net ([212.243.197.30]:58493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXZD1-00061U-MN for emacs-devel@gnu.org; Sun, 21 Feb 2016 13:58:19 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id AEDF016B47; Sun, 21 Feb 2016 19:58:15 +0100 (CET) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id hNqW-I5QecnB; Sun, 21 Feb 2016 19:58:15 +0100 (CET) Original-Received: from hal (84-73-67-69.dclient.hispeed.ch [84.73.67.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 8179A16B35; Sun, 21 Feb 2016 19:58:15 +0100 (CET) User-agent: mu4e 0.9.17; emacs 25.0.50.1 In-reply-to: <1806012502.7608447.1456049133392.JavaMail.yahoo@mail.yahoo.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 212.243.197.30 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200396 Archived-At: The library provides the wrong feature (`arbitools-mode'). It should instead provide the feature which matches the filename (but of course without the ".el" suffix): `arbitools'. Also there is a space missing in ";;;Commentary:". And you might want to consider not putting closing parens in the wrong place. You should fix that at least for the definition of `arbitools-mode'. For data, like the value of `arbitools-highlights', which is likely to be extended in the future it is okay to put closing parens on a separte line. But you should put both closing parents on the same line and indent that line correctly. Actually you should reindent the complete value. But first you need to correctly comment the commented lines, replacing ";(" with ";; (" (also in other definitions). Then mark the `defvar' and use `M-x indent-region RET'.