all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 12377@debbugs.gnu.org
Subject: bug#12377: 24.2.50; `minibuffer-prompt-properties' should respect existing faces in prompt string
Date: Thu, 28 Apr 2016 19:06:53 +0200	[thread overview]
Message-ID: <87lh3x7jde.fsf@gnus.org> (raw)
In-Reply-To: <87pot97jy0.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 28 Apr 2016 18:54:31 +0200")

It's unfortunate that read_minibuf uses this way to apply the minibuf
text properties:

	Fadd_text_properties (make_number (BEG), make_number (PT),
			      Vminibuffer_prompt_properties, Qnil);

Or rather, the design of minibuffer-prompt-properties.  It includes one
property that's pretty important for the prompt, namely `read-only', and
one that's for display only, namely `face'.  And the latter is something
that you'd want to be able to override by saying `propertize' on the
prompt, definitely.

I'm inclined to think that if the user has set any `face' properties on
the prompt, then read_minibuf should avoid setting it.  We could just
loop over the minibuffer-prompt-properties list and apply the ones that
aren't set any place in the string already?  Does that sound OK to
everybody?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no






  reply	other threads:[~2016-04-28 17:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-07 16:31 bug#12377: 24.2.50; `minibuffer-prompt-properties' should respect existing faces in prompt string Drew Adams
2014-02-09  3:11 ` Lars Ingebrigtsen
2014-02-10 22:36   ` Drew Adams
2016-04-28 16:23 ` Lars Ingebrigtsen
2016-04-28 16:38   ` Drew Adams
2016-04-28 16:54     ` Lars Ingebrigtsen
2016-04-28 17:06       ` Lars Ingebrigtsen [this message]
2016-04-29  0:21         ` Drew Adams
2016-05-01 14:54         ` Lars Ingebrigtsen
2016-06-24 16:33 ` Drew Adams
2016-06-24 17:13   ` Noam Postavsky
2016-06-24 18:57     ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lh3x7jde.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=12377@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.