From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#13764: 24.3.50; please do not use defsubst for `font-lock-(apply-highlight|fontify-anchored-keywords)' Date: Fri, 29 Apr 2016 00:31:08 +0200 Message-ID: <87lh3x2wnn.fsf@gnus.org> References: <220CC265C06944E69F89E1F29796C873@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1461882742 17421 80.91.229.3 (28 Apr 2016 22:32:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 Apr 2016 22:32:22 +0000 (UTC) Cc: 13764@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 29 00:32:09 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1avuTh-0004Xs-A9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Apr 2016 00:32:09 +0200 Original-Received: from localhost ([::1]:51431 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avuTg-00055Z-FV for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Apr 2016 18:32:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avuTd-00052q-2o for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 18:32:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avuTZ-0003ro-Sc for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 18:32:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41331) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avuTZ-0003rk-Q1 for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 18:32:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1avuTZ-0006q8-Mc for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 18:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2016 22:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13764 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13764-submit@debbugs.gnu.org id=B13764.146188267324094 (code B ref 13764); Thu, 28 Apr 2016 22:32:01 +0000 Original-Received: (at 13764) by debbugs.gnu.org; 28 Apr 2016 22:31:13 +0000 Original-Received: from localhost ([127.0.0.1]:53668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avuSn-0006GQ-8P for submit@debbugs.gnu.org; Thu, 28 Apr 2016 18:31:13 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:38519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avuSl-0006EY-KQ for 13764@debbugs.gnu.org; Thu, 28 Apr 2016 18:31:11 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1avuSi-00018t-U7; Fri, 29 Apr 2016 00:31:11 +0200 In-Reply-To: <220CC265C06944E69F89E1F29796C873@us.oracle.com> (Drew Adams's message of "Mon, 18 Feb 2013 09:24:46 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117128 Archived-At: "Drew Adams" writes: > These are not tiny, trivial functions. > > They do not fit the criteria for `defsubst' outlined in (elisp) > `Inline Functions'. And they introduce all of the disadvantages > listed there, especially this one, listed first: [...] > I see no reason why these function should not be defuns. Presumably they are that way because of efficiency concerns. Have you done benchmarking to compare the impact of these defsubsts turning into defuns? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no