From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?utf-8?Q?=C3=93scar_Fuentes?= Newsgroups: gmane.emacs.devel Subject: Re: Bisecting display bugs Date: Mon, 11 Jul 2016 19:46:42 +0200 Message-ID: <87lh18awzh.fsf@wanadoo.es> References: <5782E073.6000505@gmail.com> <837fcsdzkj.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1468259243 18779 80.91.229.3 (11 Jul 2016 17:47:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 11 Jul 2016 17:47:23 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 11 19:47:14 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bMfIX-0007k9-ID for ged-emacs-devel@m.gmane.org; Mon, 11 Jul 2016 19:47:13 +0200 Original-Received: from localhost ([::1]:35282 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMfIW-0008W0-Tu for ged-emacs-devel@m.gmane.org; Mon, 11 Jul 2016 13:47:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMfIN-0008Up-PM for emacs-devel@gnu.org; Mon, 11 Jul 2016 13:47:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMfII-0006FH-PT for emacs-devel@gnu.org; Mon, 11 Jul 2016 13:47:02 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:57139) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMfII-0006Ei-Ir for emacs-devel@gnu.org; Mon, 11 Jul 2016 13:46:58 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1bMfID-0007bW-9o for emacs-devel@gnu.org; Mon, 11 Jul 2016 19:46:53 +0200 Original-Received: from 141.red-217-125-182.dynamicip.rima-tde.net ([217.125.182.141]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 11 Jul 2016 19:46:53 +0200 Original-Received: from ofv by 141.red-217-125-182.dynamicip.rima-tde.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 11 Jul 2016 19:46:53 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 38 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 141.red-217-125-182.dynamicip.rima-tde.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cancel-Lock: sha1:zTYdvxEJ+srS6iOpfNDI8dXGFys= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205557 Archived-At: Eli Zaretskii writes: [snip] >> +Some caveats: >> + >> +- This script cleans Emacs' source directory with ‘git clean -xfd’, so >> + make sure your uncommitted changes are saved somewhere else. > > While bootstrapping after each step of bisect is safe, it makes the > run much longer, so I'd try bisecting without a bootstrap first, > especially if the range of commits to bisect is relatively small. Although that sounds good in principle, my experience tells me that taking the short path does waste more time than it saves on this case. YMMV, but too many times the bisection stopped with a build failure that wouldn't happen with bootstrap, or simply gave wrong results because the build didn't work correctly. Speaking of this, the sample script could offer bug failure detection and `git bisect skip'. [snip] >> but some are only >> +apparent through visual inspection. Since building Emacs takes a long >> +time, it can be a pain to debug these manually. > > I don't follow this logic: building is an automated process, while > visual inspection is usually very fast; the automated comparison > you are about to suggest doesn't decrease the build time. So how does > the conclusion follow? Because I have to be there in front of the terminal. And I can make mistakes. Anything that makes the bisection automatic is a big advantage. [snip]