From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Cochran Newsgroups: gmane.emacs.bugs Subject: bug#24041: 25.1.50; xwidget + -nw mode gives segfault Date: Sat, 20 Aug 2016 14:33:58 -0700 Message-ID: <87lgzrm8ft.fsf@cochranmail.com> References: <8760qwtxld.fsf@cochranmail.com> <83oa4ndhfw.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1471728926 18607 195.159.176.226 (20 Aug 2016 21:35:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 20 Aug 2016 21:35:26 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: shanemhansen@gmail.com, 24041@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 20 23:35:22 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bbDvF-0004ct-D3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Aug 2016 23:35:21 +0200 Original-Received: from localhost ([::1]:34405 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbDvC-0002ae-PD for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Aug 2016 17:35:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbDv1-0002X9-FK for bug-gnu-emacs@gnu.org; Sat, 20 Aug 2016 17:35:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bbDuv-0003iJ-UE for bug-gnu-emacs@gnu.org; Sat, 20 Aug 2016 17:35:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37674) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbDuv-0003i9-RC for bug-gnu-emacs@gnu.org; Sat, 20 Aug 2016 17:35:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bbDuv-0000sD-Js for bug-gnu-emacs@gnu.org; Sat, 20 Aug 2016 17:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Cochran Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Aug 2016 21:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24041 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24041-submit@debbugs.gnu.org id=B24041.14717288523288 (code B ref 24041); Sat, 20 Aug 2016 21:35:01 +0000 Original-Received: (at 24041) by debbugs.gnu.org; 20 Aug 2016 21:34:12 +0000 Original-Received: from localhost ([127.0.0.1]:35386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bbDu8-0000qy-HN for submit@debbugs.gnu.org; Sat, 20 Aug 2016 17:34:12 -0400 Original-Received: from mail.workgrouplinux.net ([207.195.177.82]:58173) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bbDu7-0000qp-59 for 24041@debbugs.gnu.org; Sat, 20 Aug 2016 17:34:11 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=cochranmail.com; h=from:to :cc:subject:references:date:in-reply-to:message-id:mime-version :content-type; s=dkim1; bh=EbtXYhClyfOVg+USSGuLmPaIKqo=; b=pziSO 32ahfzsq2XeGbWneEPYNM6hKisrqE3PJSVeKREYvI6zN5VjE1eflUaCHox8sEYRo ufnWUYHx/R0rKqgA20IOKaXlKlJGd8I+9KyVxLafk3acXA+GxWlQpIK29l5EzIje kKwv+H91xqpw96dMrKcsGEArxlCY0PFbWc/xxPoP2ccXtkgWMr4UHcddx5hyPOoa n0/Bkn8HUixvjixLoXkO5tdX1dtJZryMvS9H1USGNI6FM95ndXEVnImJ/oazjGXn /AXQ4gGLco1d4iwNaywi6FMwl9uIDL1biru0u8gsYT3v6o+zNvdUG+n/+uNMiIuW h78vBGpsJKPr8LnNQ== Original-Received: (qmail 20929 invoked by uid 0); 20 Aug 2016 21:34:07 -0000 Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=private; d=cochranmail.com; b=XYhoeTQDMr1EXmVFkC8cYXAhnDFVcmGp5KIKv8DM4IwF1bHgpG18MQH/gsLEtXpKjXpEg3iu8skK8MIng5ckug==; Original-Received: from 131-191-86-130.as.clicknet.org (HELO SoraLaptop) (robert@cochranmail.com@131.191.86.130) by mail.cochrantribe.org with ESMTPA; 20 Aug 2016 21:34:07 -0000 In-Reply-To: <83oa4ndhfw.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 20 Aug 2016 10:32:03 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122440 Archived-At: Eli Zaretskii writes: >> From: Robert Cochran >> Date: Fri, 19 Aug 2016 11:36:30 -0700 >> Cc: 24041@debbugs.gnu.org >> >> Anyways, so the fix here is conceptually pretty simple: have a check in >> place to ensure (display-graphic-p) returns non-nil before doing any >> xwidgets stuff. Easy enough. > > display-graphic-p accepts argument, so if a function displays on > another frame or display, it should be passed that frame or display. I guess I don't quite understand what you're trying to say here. In the particular case of `xwidget-webkit-browse-url`, the current frame is reused. I don't think it would be a particularly good idea to automatically redirect widget requests to a graphical frame. (Is that even possible? Start a graphical frame from a tty Emacs?) Again, I'm having trouble understanding what you mean. Apologies about my confusion. >> What I want to solicit feedback on before I write a patch is this: who >> should be responsible for this check? Should the function provider (the >> xwidget C 'library') check for the proper support? Or should that be >> left to the user (the Lisp that calls the xwidget functions, in this >> case `xwidget-webkit-browse-url`)? > > IMO, the check should be on the C level where the xwidget primitives > are implemented. One such place is make-xwidget; maybe there are > more. (The proper way of testing this on the C level is not by > calling display-graphic-p, but rather with check_x_display_info.) That's what my feeling was too. I'll go ahead and do it on the C level then. > Thanks. No problem. -- ~Robert Cochran GPG Fingerprint - E778 2DD4 FEA6 6A68 6F26 AD2D E5C3 EB36 4886 8871