From: Robert Cochran <robert-emacs@cochranmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: shanemhansen@gmail.com, 24041@debbugs.gnu.org
Subject: bug#24041: 25.1.50; xwidget + -nw mode gives segfault
Date: Sat, 20 Aug 2016 14:33:58 -0700 [thread overview]
Message-ID: <87lgzrm8ft.fsf@cochranmail.com> (raw)
In-Reply-To: <83oa4ndhfw.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 20 Aug 2016 10:32:03 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Robert Cochran <robert-emacs@cochranmail.com>
>> Date: Fri, 19 Aug 2016 11:36:30 -0700
>> Cc: 24041@debbugs.gnu.org
>>
>> Anyways, so the fix here is conceptually pretty simple: have a check in
>> place to ensure (display-graphic-p) returns non-nil before doing any
>> xwidgets stuff. Easy enough.
>
> display-graphic-p accepts argument, so if a function displays on
> another frame or display, it should be passed that frame or display.
I guess I don't quite understand what you're trying to say here. In the
particular case of `xwidget-webkit-browse-url`, the current frame
is reused. I don't think it would be a particularly good idea to
automatically redirect widget requests to a graphical frame. (Is that
even possible? Start a graphical frame from a tty Emacs?)
Again, I'm having trouble understanding what you mean. Apologies about
my confusion.
>> What I want to solicit feedback on before I write a patch is this: who
>> should be responsible for this check? Should the function provider (the
>> xwidget C 'library') check for the proper support? Or should that be
>> left to the user (the Lisp that calls the xwidget functions, in this
>> case `xwidget-webkit-browse-url`)?
>
> IMO, the check should be on the C level where the xwidget primitives
> are implemented. One such place is make-xwidget; maybe there are
> more. (The proper way of testing this on the C level is not by
> calling display-graphic-p, but rather with check_x_display_info.)
That's what my feeling was too. I'll go ahead and do it on the C level
then.
> Thanks.
No problem.
--
~Robert Cochran
GPG Fingerprint - E778 2DD4 FEA6 6A68 6F26 AD2D E5C3 EB36 4886 8871
next prev parent reply other threads:[~2016-08-20 21:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 16:04 bug#24041: 25.1.50; xwidget + -nw mode gives segfault Shane Hansen
2016-08-19 18:36 ` Robert Cochran
2016-08-20 7:32 ` Eli Zaretskii
2016-08-20 21:33 ` Robert Cochran [this message]
2016-08-21 2:40 ` Eli Zaretskii
2016-08-22 2:12 ` Robert Cochran
2016-08-22 14:41 ` Eli Zaretskii
2016-08-22 18:30 ` Robert Cochran
2016-08-22 18:49 ` Eli Zaretskii
2016-08-22 19:52 ` joakim
2016-08-22 20:28 ` Robert Cochran
2016-08-23 2:40 ` Eli Zaretskii
2019-08-28 20:04 ` Lars Ingebrigtsen
2019-08-29 11:00 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgzrm8ft.fsf@cochranmail.com \
--to=robert-emacs@cochranmail.com \
--cc=24041@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=shanemhansen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.