From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Cochran Newsgroups: gmane.emacs.bugs Subject: bug#24133: 25.1.50; Some checkdoc.el functions use call-interactively incorrectly Date: Sat, 27 Aug 2016 11:38:06 -0700 Message-ID: <87lgzif46p.fsf@cochranmail.com> References: <2eb6d6f3-09e8-093b-568f-634dced3fcd6@gmail.com> <87bn0oqlk7.fsf@cochranmail.com> <87wpj2syrw.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1472323183 4778 195.159.176.226 (27 Aug 2016 18:39:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 27 Aug 2016 18:39:43 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: Matthew Malcomson , 24133@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 27 20:39:39 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdiW1-0000aG-OT for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Aug 2016 20:39:39 +0200 Original-Received: from localhost ([::1]:36868 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdiVz-0001a9-At for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Aug 2016 14:39:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47203) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdiVV-0001Nu-Ow for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2016 14:39:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdiVS-0000lC-G8 for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2016 14:39:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdiVS-0000l8-4w for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2016 14:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bdiVS-000722-0T for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2016 14:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Cochran Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Aug 2016 18:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24133 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24133-submit@debbugs.gnu.org id=B24133.147232309426971 (code B ref 24133); Sat, 27 Aug 2016 18:39:01 +0000 Original-Received: (at 24133) by debbugs.gnu.org; 27 Aug 2016 18:38:14 +0000 Original-Received: from localhost ([127.0.0.1]:42202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdiUg-00070x-4J for submit@debbugs.gnu.org; Sat, 27 Aug 2016 14:38:14 -0400 Original-Received: from mail.workgrouplinux.net ([207.195.177.82]:53884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdiUe-00070o-3I for 24133@debbugs.gnu.org; Sat, 27 Aug 2016 14:38:13 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=cochranmail.com; h=from:to :cc:subject:references:date:in-reply-to:message-id:mime-version :content-type; s=dkim1; bh=kO+cXAaOegyprEBWzh3hZgaAZcU=; b=1N+WI NGtN/7ywX/rxp80h+mhyyBZtOQeu8BTgn6kAAf/3E9JAhdx7iZzWMO+xciq1lnrk /92En6q4DYjOCmR8yZXmBzGtfDlSzOWEVWh8B0DeKm2DMavao13S9i1WTbF/D+f9 EqxRv6uPQf0wfL/Iy86gML1MwC7LusNJz/wA5FAaus2n+pJqZtluObjOVMNXCh9B 9qcNQZGnqB/HGgifXtnC+us+cfek0MlAahuAFeghQSShBYn/4gvbzX7gRADwGx+A G/szfgspi4I2SloLA3oZQigMOwC8uSB+XRU+YYKj6levlXwmGervqK5JI/3k6mT1 yGnl2VimZodCcBjfg== Original-Received: (qmail 30926 invoked by uid 0); 27 Aug 2016 18:38:08 -0000 Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=private; d=cochranmail.com; b=XPHXXGLotcFakSjdsbHed7Xuw2UbYidEvkYbSl+QxGpWTG3jSyEtOraXrIPLIYe/P/6H87OwHaxJWB8+HHX4aQ==; Original-Received: from 131-191-86-130.as.clicknet.org (HELO SoraLaptop) (robert@cochranmail.com@131.191.86.130) by mail.cochrantribe.org with ESMTPA; 27 Aug 2016 18:38:08 -0000 In-Reply-To: <87wpj2syrw.fsf@users.sourceforge.net> (npostavs's message of "Fri, 26 Aug 2016 22:58:59 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122725 Archived-At: --=-=-= Content-Type: text/plain I believe I've fixed all of the mentioned issues in this new patch. Apologies for having not gotten it correct the first time; I'll keep in mind to better review before sending in the future. ----- --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-uses-of-call-interactively-in-lisp-emacs-lisp-ch.patch Content-Description: Patch to fix checkdoc's misuse of call-interactively >From 335663f3d9ba0de2f970f2c32626aa5acef17118 Mon Sep 17 00:00:00 2001 From: Robert Cochran Date: Fri, 19 Aug 2016 18:03:24 -0700 Subject: [PATCH] Fix uses of (call-interactively) in lisp/emacs-lisp/checkdoc.el Passing the prefix argument as the 3rd argument to 'call-interactively' causes the prefix argument to be interpreted as events, which is not only wrong, but also causes a type error, as 'current-prefix-arg' can never be a vector as 'call-interactively' expects. 'call-interactively' automatically passes its prefix argument to the called function, so just do that, eliminating faulty behavior. * lisp/emacs-lisp/checkdoc.el (checkdoc-ispell) (checkdoc-ispell-current-buffer) (checkdoc-ispell-interactive) (checkdoc-ispell-message-text) (checkdoc-ispell-start) (checkdoc-ispell-continue) (checkdoc-ispell-comments) (checkdoc-ispell-defun): Do not pass 'current-prefix-arg' to 'call-interactively' as an event vector; merely allow it to propagate forward to the interactive call. --- lisp/emacs-lisp/checkdoc.el | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el index 3a81ade..769c2fe 100644 --- a/lisp/emacs-lisp/checkdoc.el +++ b/lisp/emacs-lisp/checkdoc.el @@ -1062,7 +1062,7 @@ checkdoc-ispell Prefix argument is the same as for `checkdoc'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc nil current-prefix-arg))) + (call-interactively #'checkdoc))) ;;;###autoload (defun checkdoc-ispell-current-buffer () @@ -1071,7 +1071,7 @@ checkdoc-ispell-current-buffer Prefix argument is the same as for `checkdoc-current-buffer'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc-current-buffer nil current-prefix-arg))) + (call-interactively #'checkdoc-current-buffer))) ;;;###autoload (defun checkdoc-ispell-interactive () @@ -1080,7 +1080,7 @@ checkdoc-ispell-interactive Prefix argument is the same as for `checkdoc-interactive'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc-interactive nil current-prefix-arg))) + (call-interactively #'checkdoc-interactive))) ;;;###autoload (defun checkdoc-ispell-message-interactive () @@ -1099,7 +1099,7 @@ checkdoc-ispell-message-text Prefix argument is the same as for `checkdoc-message-text'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc-message-text nil current-prefix-arg))) + (call-interactively #'checkdoc-message-text))) ;;;###autoload (defun checkdoc-ispell-start () @@ -1108,7 +1108,7 @@ checkdoc-ispell-start Prefix argument is the same as for `checkdoc-start'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc-start nil current-prefix-arg))) + (call-interactively #'checkdoc-start))) ;;;###autoload (defun checkdoc-ispell-continue () @@ -1117,7 +1117,7 @@ checkdoc-ispell-continue Prefix argument is the same as for `checkdoc-continue'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc-continue nil current-prefix-arg))) + (call-interactively #'checkdoc-continue))) ;;;###autoload (defun checkdoc-ispell-comments () @@ -1126,7 +1126,7 @@ checkdoc-ispell-comments Prefix argument is the same as for `checkdoc-comments'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc-comments nil current-prefix-arg))) + (call-interactively #'checkdoc-comments))) ;;;###autoload (defun checkdoc-ispell-defun () @@ -1135,7 +1135,7 @@ checkdoc-ispell-defun Prefix argument is the same as for `checkdoc-defun'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc-defun nil current-prefix-arg))) + (call-interactively #'checkdoc-defun))) ;;; Error Management ;; -- 2.7.4 --=-=-= Content-Type: text/plain ----- Thanks, -- ~Robert Cochran GPG Fingerprint - E778 2DD4 FEA6 6A68 6F26 AD2D E5C3 EB36 4886 8871 --=-=-=--