From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Damien Cassou Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master bd22beb: Add seq-random-elt to seq.el Date: Tue, 25 Oct 2016 16:23:38 +0200 Message-ID: <87lgxctslx.fsf@cassou.me> References: <20161025103309.2182.7179@vcs.savannah.gnu.org> <20161025103309.77C982201D5@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1477405491 26111 195.159.176.226 (25 Oct 2016 14:24:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 25 Oct 2016 14:24:51 +0000 (UTC) User-Agent: Notmuch/0.22 (http://notmuchmail.org) Emacs/25.1.1 (x86_64-unknown-linux-gnu) To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 25 16:24:45 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bz2eT-0004D8-2b for ged-emacs-devel@m.gmane.org; Tue, 25 Oct 2016 16:24:29 +0200 Original-Received: from localhost ([::1]:54953 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz2eV-0008RL-8t for ged-emacs-devel@m.gmane.org; Tue, 25 Oct 2016 10:24:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz2dr-000871-0R for emacs-devel@gnu.org; Tue, 25 Oct 2016 10:23:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bz2dm-0002x6-UX for emacs-devel@gnu.org; Tue, 25 Oct 2016 10:23:51 -0400 Original-Received: from mail.choca.pics ([62.210.108.126]:53816) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bz2dm-0002wu-Ov for emacs-devel@gnu.org; Tue, 25 Oct 2016 10:23:46 -0400 Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 74AD5232BFE5; Tue, 25 Oct 2016 16:23:45 +0200 (CEST) Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id cjq609uNPrJw; Tue, 25 Oct 2016 16:23:41 +0200 (CEST) Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id C7130232C001; Tue, 25 Oct 2016 16:23:41 +0200 (CEST) X-Virus-Scanned: amavisd-new at choca.pics Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id idcHuM7EXbxK; Tue, 25 Oct 2016 16:23:41 +0200 (CEST) Original-Received: from luz4 (31-211-216-84.customers.ownit.se [31.211.216.84]) by mail.choca.pics (Postfix) with ESMTPSA id 70F77232BFE5; Tue, 25 Oct 2016 16:23:41 +0200 (CEST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 62.210.108.126 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:208767 Archived-At: Stefan Monnier writes: >> +Return nil if SEQUENCE is nil." >> + (if (seq-empty-p sequence) >> + (error "Sequence cannot be empty") > > Hmm... which is it? I'm not sure I understand your question. I could have written: (error "Sequence %s cannot be empty" sequence) but I thought it was useless because SEQUENCE is empty and nothing meaningful would be added to the message. -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill