From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Matthew Carter Newsgroups: gmane.emacs.devel Subject: Re: Unnecessary variable shr-start Date: Sat, 03 Dec 2016 01:54:17 -0500 Organization: Ahungry (http://ahungry.com) Message-ID: <87lgvx7bae.fsf@ahungry.com> References: <87zikeji0s.fsf@topbug.net> <87pola2cjh.fsf@web.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1480748085 11235 195.159.176.226 (3 Dec 2016 06:54:45 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 3 Dec 2016 06:54:45 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: emacs-devel@gnu.org, Hong Xu To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 03 07:54:39 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cD4DW-0001Q6-L9 for ged-emacs-devel@m.gmane.org; Sat, 03 Dec 2016 07:54:38 +0100 Original-Received: from localhost ([::1]:38029 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cD4DX-0002DH-40 for ged-emacs-devel@m.gmane.org; Sat, 03 Dec 2016 01:54:39 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cD4DO-0002DB-Nu for emacs-devel@gnu.org; Sat, 03 Dec 2016 01:54:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cD4DL-0001Qb-Ls for emacs-devel@gnu.org; Sat, 03 Dec 2016 01:54:30 -0500 Original-Received: from li130-200.members.linode.com ([69.164.215.200]:42768 helo=mail.ahungry.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cD4DL-0001QG-Ir for emacs-devel@gnu.org; Sat, 03 Dec 2016 01:54:27 -0500 Original-Received: from localhost (ahungry.com [127.0.0.1]) by mail.ahungry.com (Postfix) with ESMTP id 1F704118035; Sat, 3 Dec 2016 01:54:26 -0500 (EST) X-Virus-Scanned: amavisd-new at ahungry.com Original-Received: from mail.ahungry.com ([127.0.0.1]) by localhost (mail.ahungry.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id YtISJpSeku8X; Sat, 3 Dec 2016 01:54:19 -0500 (EST) Original-Received: from Prometheus (99-40-9-245.lightspeed.livnmi.sbcglobal.net [99.40.9.245]) by mail.ahungry.com (Postfix) with ESMTPSA id 686BA118034; Sat, 3 Dec 2016 01:54:19 -0500 (EST) In-Reply-To: <87pola2cjh.fsf@web.de> (Michael Heerdegen's message of "Fri, 02 Dec 2016 23:26:10 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 69.164.215.200 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209968 Archived-At: Michael Heerdegen writes: > Hong Xu writes: > >> In the current master branch, it seems that the variable shr-start has >> never been used in any sensible way: Every time its value is referred, >> it is bound to nil. Should it be considered to be removed? > > Are you sure it is always bound to nil when referenced in `shr-tag-a'? > I would expect it can be changed by side effect in the body, and the > let-binding is there to make that change temporary. > > > Michael. > It looks like it's bound at the top defvar level (and changed via setq in the img function), so those let's to nil in certain functions are likely to inhibit the current setting when those functions begin to run. -- Matthew Carter (m@ahungry.com) http://ahungry.com