From: phillip.lord@russet.org.uk (Phillip Lord)
To: npostavs@users.sourceforge.net
Cc: 25360@debbugs.gnu.org
Subject: bug#25360: File mode specification errors during building
Date: Tue, 24 Jan 2017 12:42:09 +0000 [thread overview]
Message-ID: <87lgu039zy.fsf@russet.org.uk> (raw)
In-Reply-To: <87d1fdvp31.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Mon, 23 Jan 2017 09:16:34 -0500")
npostavs@users.sourceforge.net writes:
> phillip.lord@russet.org.uk (Phillip Lord) writes:
>
>> phillip.lord@russet.org.uk (Phillip Lord) writes:
>>
>> The final version of this is on fix/bootstrap-build-minimize-squash,
>> tested on windows and gnu/linux. Comments welcome or I'll push this to
>> master tomorrow.
>
> Just a few minor formatting things:
>
>> Remove conditional includes from bootstrap
>>
>> * lisp/loadup.el: No longer load optional includes during bootstrap
>> dumping.
>> * lisp/ldefs-boot-auto.el: Regenerate.
>> * lisp/ldefs-boot-manual.el: Add two autoloads.
>>
>> Previously, bootstrap-emacs includes optional functionality, depending
>> on the platform which is not needed for bootstrap function. As a result,
>> bootstrap-emacs contains different functions in different
>> circumstances. If ldefs-boot-auto.el is generated, then loaded functions
>> will not be added to ldefs-boot-auto.el, although they may be required
>> during some builds. With this change, bootstrap-emacs should always
>> behave the same way and, therefore, require the same autoloads.
>
> Sentences should end in double space, and summary should before
> ChangeLog entry.
Double space I seem to always get wrong, and I need to check my
configuration to stop if removing them.
The summary before the changelog, I am a bit less sure on. I see both
forms in use.
>> +(autoload 'dos-convert-standard-filename "dos-fns.el" nil nil nil)
>> +(autoload ' w32-convert-standard-filename "w32-fns.el" nil nil nil)
>
> Extra space here.
>
> In the last commit, "Add error handling to magic-mode-alist":
>
>> + (t
>> + (error
>> + "Problem in magic-mode-alist with element %s" re))
>> + ))))))
>
> The close paren placement looks odd.
Will address these!
Did you have chance to check this on a bootstrap build? Would be good to
know I am not the only one.
Phil
next prev parent reply other threads:[~2017-01-24 12:42 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 20:28 bug#25360: File mode specification errors during building Glenn Morris
2017-01-07 8:03 ` Eli Zaretskii
2017-01-09 13:06 ` Phillip Lord
2017-01-10 10:21 ` Phillip Lord
2017-01-10 15:13 ` Eli Zaretskii
2017-01-10 18:40 ` Phillip Lord
2017-01-10 18:48 ` Eli Zaretskii
2017-01-13 14:08 ` Phillip Lord
2017-01-13 14:19 ` Eli Zaretskii
2017-01-13 21:31 ` Phillip Lord
2017-01-14 19:09 ` Glenn Morris
2017-01-15 22:05 ` Phillip Lord
2017-01-15 23:53 ` npostavs
2017-01-16 0:07 ` Phillip Lord
2017-01-16 0:27 ` npostavs
2017-01-17 17:38 ` Glenn Morris
2017-01-17 21:49 ` Phillip Lord
2017-01-17 17:42 ` Glenn Morris
2017-01-17 22:04 ` Phillip Lord
2017-01-18 1:11 ` npostavs
2017-01-19 10:45 ` Phillip Lord
2017-01-19 16:05 ` Eli Zaretskii
2017-01-19 17:06 ` Noam Postavsky
2017-01-20 13:43 ` Phillip Lord
2017-01-21 21:11 ` Phillip Lord
2017-01-23 12:44 ` Phillip Lord
2017-01-23 14:16 ` npostavs
2017-01-24 12:42 ` Phillip Lord [this message]
2017-01-24 13:12 ` npostavs
2017-01-23 15:38 ` Eli Zaretskii
2017-01-24 12:51 ` Phillip Lord
2017-01-24 15:52 ` Eli Zaretskii
2017-02-06 10:31 ` Phillip Lord
2017-02-06 15:41 ` Eli Zaretskii
2017-02-13 2:06 ` Glenn Morris
2017-02-13 2:15 ` Glenn Morris
2017-02-13 2:22 ` Glenn Morris
2017-02-14 13:46 ` Phillip Lord
2017-02-19 0:36 ` Glenn Morris
2017-02-19 21:40 ` Phillip Lord
2017-02-22 19:08 ` Glenn Morris
2017-03-01 16:55 ` Phillip Lord
2017-03-02 15:20 ` Eli Zaretskii
2017-03-02 17:57 ` martin rudalics
2017-03-02 20:12 ` Eli Zaretskii
2017-03-04 10:02 ` Eli Zaretskii
2017-03-04 10:32 ` Phillip Lord
2017-03-04 11:11 ` Eli Zaretskii
2017-03-04 11:28 ` Eli Zaretskii
2017-03-06 15:33 ` Phillip Lord
2017-03-06 19:56 ` Noam Postavsky
2017-03-06 20:53 ` Eli Zaretskii
2017-03-06 21:10 ` Noam Postavsky
2017-03-06 21:25 ` Phillip Lord
2017-03-07 3:31 ` Eli Zaretskii
2017-03-07 12:26 ` Phillip Lord
2017-03-07 15:28 ` Phillip Lord
2017-03-07 16:01 ` Eli Zaretskii
2017-03-07 18:25 ` Noam Postavsky
2017-03-07 19:35 ` Phillip Lord
2017-03-08 12:31 ` Phillip Lord
2017-03-07 15:51 ` Eli Zaretskii
2017-03-05 18:26 ` Andy Moreton
2017-03-05 18:58 ` Phillip Lord
2017-03-05 20:08 ` Eli Zaretskii
2017-03-06 12:07 ` Andy Moreton
2017-03-06 16:31 ` Phillip Lord
2017-03-06 23:26 ` Andy Moreton
2017-03-06 16:30 ` Phillip Lord
2017-03-06 18:38 ` Eli Zaretskii
2017-01-25 22:46 ` Glenn Morris
2017-01-27 16:25 ` Phillip Lord
2017-02-13 2:07 ` Glenn Morris
2017-01-13 14:22 ` Eli Zaretskii
2017-01-13 16:47 ` Phillip Lord
2017-01-10 17:47 ` Glenn Morris
2017-01-10 18:50 ` Phillip Lord
2017-01-11 16:36 ` Richard Stallman
2017-01-13 14:05 ` Phillip Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgu039zy.fsf@russet.org.uk \
--to=phillip.lord@russet.org.uk \
--cc=25360@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.