From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Joakim Jalap Newsgroups: gmane.emacs.devel Subject: Re: Imenu for cobol-mode Date: Thu, 16 Mar 2017 08:56:46 +0100 Message-ID: <87lgs5bqo1.fsf@fastmail.com> References: <87a892kym7.fsf@fastmail.com> <87h934kfgx.fsf@fastmail.com> <87zigmib9h.fsf@fastmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1489651029 14616 195.159.176.226 (16 Mar 2017 07:57:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 16 Mar 2017 07:57:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (berkeley-unix) Cc: emacs-devel@gnu.org To: Edward Hart Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 16 08:57:03 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coQHL-0002q5-FR for ged-emacs-devel@m.gmane.org; Thu, 16 Mar 2017 08:56:59 +0100 Original-Received: from localhost ([::1]:41501 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1coQHR-0001yA-JC for ged-emacs-devel@m.gmane.org; Thu, 16 Mar 2017 03:57:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1coQHF-0001u0-12 for emacs-devel@gnu.org; Thu, 16 Mar 2017 03:56:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1coQHB-00009T-TC for emacs-devel@gnu.org; Thu, 16 Mar 2017 03:56:53 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:34899) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1coQHB-00009F-9o for emacs-devel@gnu.org; Thu, 16 Mar 2017 03:56:49 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 775DD207D6; Thu, 16 Mar 2017 03:56:48 -0400 (EDT) Original-Received: from frontend1 ([10.202.2.160]) by compute4.internal (MEProxy); Thu, 16 Mar 2017 03:56:48 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=Lc3SkFnpt15nd1NTcqg0AXGSiZU=; b=KoHt4gh1l pSjePf1YQcXapGPHBUofhwpT3zPI5FMwHrEj0O0QoMQ+Mb4bXoHwxBl5GDIvKdGW aSN8DHF1h60sD6D1Ox31I0z7HsJz8er6ZQXTN1eY89NT+C1esJ5GwW+SkJMZGCsB C9tGRi3X95B1bFc5hBTPeixh+kxfTn7p/5wOoRDj4HVKTOiFD5toiCWQ49GbiXO1 wQhoPoCBkIgJgpO5WG4PSAF4uB198t/Sb2Jn+835qN9AzWQGyft4WTSFVbw6q6BW QBvDHavw8WoJgiR7mVi6/tnP1gcebLEXFPgpT36bbB2uFA7iBXiACCbrUT0lUHKO 3b1/AiDvYQpOw== DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=Lc3SkFnpt15nd1NTcq g0AXGSiZU=; b=a1ePG5Ketm73aJ3zfzpKxKiLkjWKFMa2iWX0Xrd/KQ2RAyTWnj J0RfPSAoc/tf88zOiB/2K/ISNZEAmffg5itDLquLz7uNwTYXcFoMSbYXnLX0rdw8 jp9WmGEoLtRvld0iB3QQkVVS+a0vX5RkVeXAWmUW5Bp0khX9ZKpC7s3UoCYVLX05 ZYupDnhMEAlt+ZjsxNcu4LcxKteZbclKA79ufv9KFL5Z19+4KyAVijud1QMjT44x j8tmDzvwrGPfZYUx4CgVZNrEeGAsrVE/gfLVJYvqDbl6iI6bruNB8jeESd7MZ8FB ldytG5WYVBx5YD+QcB9Q8UOrFLYntMxE/ypg== X-ME-Sender: X-Sasl-enc: rao22NtiD5cClIAzJvt6qif+HMXziCmfk4irlLWc+vj2 1489651008 Original-Received: from genserv (unknown [5.150.202.248]) by mail.messagingengine.com (Postfix) with ESMTPA id CB9AD7E1DC; Thu, 16 Mar 2017 03:56:47 -0400 (EDT) In-Reply-To: (Edward Hart's message of "Wed, 15 Mar 2017 21:14:53 +0000") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.25 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213072 Archived-At: Edward Hart writes: > HI Joakim, Hi again :) > Sorry for not getting back to you sooner (my problem sheets have > become quite difficult this term). No problem at all :) > The peek and goto features work very well. I also appreciate the extra > code comments. Well the peek and goto functions are somewhat dirty hacks, the real solution there would be to use xref. But would you like to keep them in anyway? >> So now the procedure division itself gets an entry under "PROCEDURE DIVISION" or "$subprogram_name PD" with the name of the subprogram/function. WDYT? > > I think "PD header" would be a good name. OK. "PD header" or "PD HEADER"? > I noticed you added (require 'seq) to the file. What do you use the > library for? It would be nice to avoid having dependencies. Just for seq-find in cobol--find-definition. I just got confused by the many different ways to find something in a list, and seq-find seemed like the simplest option. I could use something else. > I've found one extra bug: the functions don't index index-names. Their > declaration is of the form "INDEXED \\(BY\\)? (\w+)". It won't be > possible to merge it with the generic declaration regexp, since the > INDEXED clause often appears at the ends of lines, within another > item's declaration. Right, I will get to work on this :) -- Jocke