Re: [Emacs-diffs] master a62437d: Don't add `search-failed' to ignored errors in info.el (Bug#6106)

Re: [Emacs-diffs] master a62437d: Don't add `search-failed' to ignored errors in info.el (Bug#6106)

[Stefan Monnier]

>     Don't add `search-failed' to ignored errors in info.el (Bug#6106)

Good, thanks.

> -	  (signal 'search-failed (list "\n\^_"))))
> +	  (user-error "Search failed: `\n\^_'")))

This one doesn't look like a user-error: the \n\^_ sequence is internal
to Info files and mostly invisible to the user, so either we change the
text so as to report the message in user-understandable terms, or we
keep this as a (signal 'search-failed' ...).


        Stefan

Re: [Emacs-diffs] master a62437d: Don't add `search-failed' to ignored errors in info.el (Bug#6106)

[Noam Postavsky]

On Tue, Mar 28, 2017 at 9:55 AM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>
>> -       (signal 'search-failed (list "\n\^_"))))
>> +       (user-error "Search failed: `\n\^_'")))
>
> This one doesn't look like a user-error: the \n\^_ sequence is internal
> to Info files and mostly invisible to the user, so either we change the
> text so as to report the message in user-understandable terms, or we
> keep this as a (signal 'search-failed' ...).

Right. While I'm taking a second look at this, do you think the search
for "\n* Menu: " in Info-complete-menu-item should be a user error?

--- i/lisp/info.el
+++ w/lisp/info.el
@@ -2699,7 +2699,8 @@ Info-complete-menu-item
             (orignode Info-current-node)
             nextnode)
         (goto-char (point-min))
-        (search-forward "\n* Menu:")
+        (unless (search-forward "\n* Menu:" nil t)
+          (user-error "No menu in this node"))
         (cond
          ((eq (car-safe action) 'boundaries) nil)
          ((eq action 'lambda)

Re: [Emacs-diffs] master a62437d: Don't add `search-failed' to ignored errors in info.el (Bug#6106)

[Stefan Monnier]

> -        (search-forward "\n* Menu:")
> +        (unless (search-forward "\n* Menu:" nil t)
> +          (user-error "No menu in this node"))

Looks good, thanks,


        Stefan

Re: [Emacs-diffs] master a62437d: Don't add `search-failed' to ignored errors in info.el (Bug#6106)

[Noam Postavsky]

On Tue, Mar 28, 2017 at 10:54 AM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>> -        (search-forward "\n* Menu:")
>> +        (unless (search-forward "\n* Menu:" nil t)
>> +          (user-error "No menu in this node"))
>
> Looks good, thanks,

Pushed [1: d707ba8469]

1: 2017-03-28 21:25:17 -0400 d707ba846902128572f420241897cbb966363ede
  Adjust some search failure errors in info.el

Re: [Emacs-diffs] master a62437d: Don't add `search-failed' to ignored errors in info.el (Bug#6106)

[Mark Oteiza]

Noam Postavsky <npostavs@gmail.com> writes:

> On Tue, Mar 28, 2017 at 10:54 AM, Stefan Monnier
> <monnier@iro.umontreal.ca> wrote:
>>> -        (search-forward "\n* Menu:")
>>> +        (unless (search-forward "\n* Menu:" nil t)
>>> +          (user-error "No menu in this node"))
>>
>> Looks good, thanks,
>
> Pushed [1: d707ba8469]
>
> 1: 2017-03-28 21:25:17 -0400 d707ba846902128572f420241897cbb966363ede
>   Adjust some search failure errors in info.el

These changes break isearching through an info manual--in particular, an
incremental search can no longer cross nodes.

  I-search: cats [(user-error Search failed: `cats' (end of node))]

Re: [Emacs-diffs] master a62437d: Don't add `search-failed' to ignored errors in info.el (Bug#6106)

[Noam Postavsky]

On Fri, Mar 31, 2017 at 12:06 AM, Mark Oteiza <mvoteiza@udel.edu> wrote:
>
> These changes break isearching through an info manual--in particular, an
> incremental search can no longer cross nodes.
>
>   I-search: cats [(user-error Search failed: `cats' (end of node))]

Oops, indeed my fix is no good. I should have defined a new
`user-search-failed' with `user-error' and `search-failed' as parents
and signaled that instead of switching to plain `user-error'. I will
send a patch along those lines to Bug#6106 in a day or two.