bug#20761: 25.0.50.1, beginning-of-defun matches inside string

bug#20761: 25.0.50.1, beginning-of-defun matches inside string

[Andreas Röhler]

emacs -Q

With cursor at end of string below:

(defun asdf ()
   "
(defun foo1 (&optional beg end)
   sdsd"
)

;;;

C-M-a stops  inside string at "(defun foo1"

GNU Emacs 25.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.24.23) of 2015-06-07

Solution:

beginning-of-defun-raw must check if being inside string.

bug#20761: 25.0.50.1, beginning-of-defun matches inside string

[Glenn Morris]

Andreas Röhler wrote:

> (defun asdf ()
>   "
> (defun foo1 (&optional beg end)
>   sdsd"
> )

Unescaped paren in column 0.

bug#20761: 25.0.50.1, beginning-of-defun matches inside string

[Andreas Röhler]

Am 07.06.2015 um 20:13 schrieb Glenn Morris:
> Andreas Röhler wrote:
>
>> (defun asdf ()
>>    "
>> (defun foo1 (&optional beg end)
>>    sdsd"
>> )
> Unescaped paren in column 0.

Can't a string have that?

bug#20761: 25.0.50.1, beginning-of-defun matches inside string

[Nicolas Richard]

Andreas Röhler <andreas.roehler@easy-emacs.de> writes:
> Am 07.06.2015 um 20:13 schrieb Glenn Morris:
>> Andreas Röhler wrote:
>>
>>> (defun asdf ()
>>>    "
>>> (defun foo1 (&optional beg end)
>>>    sdsd"
>>> )
>> Unescaped paren in column 0.
>
> Can't a string have that?

They can, but the convention is to not do that :
(info "(emacs) Left Margin Paren")

It's also in the docstring of beginning-of-defun
> When `open-paren-in-column-0-is-defun-start' is non-nil, a defun
> is assumed to start where there is a char with open-parenthesis
> syntax at the beginning of a line.

-- 
Nico.

bug#20761: 25.0.50.1, beginning-of-defun matches inside string

[Andreas Röhler]

Am 08.06.2015 um 07:18 schrieb Nicolas Richard:
> Andreas Röhler <andreas.roehler@easy-emacs.de> writes:
>> Am 07.06.2015 um 20:13 schrieb Glenn Morris:
>>> Andreas Röhler wrote:
>>>
>>>> (defun asdf ()
>>>>     "
>>>> (defun foo1 (&optional beg end)
>>>>     sdsd"
>>>> )
>>> Unescaped paren in column 0.
>> Can't a string have that?
> They can, but the convention is to not do that :
> (info "(emacs) Left Margin Paren")

An oddity from times, where parse-partial-sexp was not available, time 
to get rid of that.


> It's also in the docstring of beginning-of-defun
>> When `open-paren-in-column-0-is-defun-start' is non-nil, a defun
>> is assumed to start where there is a char with open-parenthesis
>> syntax at the beginning of a line.

Ditto, just legacy, no need for that.

bug#20761: 25.0.50.1, beginning-of-defun matches inside string

[Andreas Röhler]

Am 07.06.2015 um 19:21 schrieb Andreas Röhler:
> emacs -Q
>
> With cursor at end of string below:
>
> (defun asdf ()
>   "
> (defun foo1 (&optional beg end)
>   sdsd"
> )
>
> ;;;
>
> C-M-a stops  inside string at "(defun foo1"
>
> GNU Emacs 25.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.24.23) of 
> 2015-06-07
>
> Solution:
>
> beginning-of-defun-raw must check if being inside string.
>
>
>

This should fix it:

(defun ar-beginning-of-defun (&optional arg)
   "Move to the beginning of a function definition.

Returns position, if successful, nil otherwise

Calls `beginning-of-defun-function', when set "
   (interactive "P")
   (unless (bobp)
     (skip-chars-backward " \t\r\n\f")
     (forward-char -1)
     (let ((pos (car-safe (nth 9 (parse-partial-sexp (point-min) 
(point))))))
       (if beginning-of-defun-function
       (funcall beginning-of-defun-function arg)
     (and pos
          (goto-char pos))))))

Optional arg here is for special needs, switches between class and 
method defs for example.

bug#20761: 25.0.50.1, beginning-of-defun matches inside string

[npostavs]

retitle 20761 beginning-of-defun matches column 0 paren inside string literal
forcemerge 20761 20284
tags 20761 wontfix
quit

Andreas Röhler <andreas.roehler@easy-emacs.de> writes:

> This should fix it:
>
> (defun ar-beginning-of-defun (&optional arg)
>   "Move to the beginning of a function definition.
>
> Returns position, if successful, nil otherwise
>
> Calls `beginning-of-defun-function', when set "
>   (interactive "P")
>   (unless (bobp)
>     (skip-chars-backward " \t\r\n\f")
>     (forward-char -1)
>     (let ((pos (car-safe (nth 9 (parse-partial-sexp (point-min) (point))))))
>       (if beginning-of-defun-function
>       (funcall beginning-of-defun-function arg)
>     (and pos
>          (goto-char pos))))))

M-x find-library org RET
M->
(benchmark 1 '(ar-beginning-of-defun)) ; Elapsed time: 0.414771s, also it puts point in the wrong place
(benchmark 1 '(beginning-of-defun))    ; Elapsed time: 0.000126s
M-: (setq open-paren-in-column-0-is-defun-start nil)
(benchmark 1 '(beginning-of-defun))    ; Elapsed time: 0.002505s