From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#19740: 25.0.50; Bad comment indentation by `C-M-q' in `emacs-lisp-mode' Date: Wed, 05 Jul 2017 23:00:03 -0400 Message-ID: <87lgo2gtho.fsf@users.sourceforge.net> References: <1580667c-4ee3-48b8-bbb7-cf6f41c36078@default> <878tkut9b3.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1499309955 22620 195.159.176.226 (6 Jul 2017 02:59:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 6 Jul 2017 02:59:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 19740@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 06 04:59:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSx0U-0005Sg-LC for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Jul 2017 04:59:06 +0200 Original-Received: from localhost ([::1]:48986 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSx0a-0001ko-5C for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Jul 2017 22:59:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSx0T-0001jh-Uw for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2017 22:59:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSx0Q-0004dD-QF for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2017 22:59:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51327) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSx0Q-0004d2-NY for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2017 22:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dSx0Q-0000ZH-GU for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2017 22:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Jul 2017 02:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19740 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch Original-Received: via spool by 19740-submit@debbugs.gnu.org id=B19740.14993099152145 (code B ref 19740); Thu, 06 Jul 2017 02:59:02 +0000 Original-Received: (at 19740) by debbugs.gnu.org; 6 Jul 2017 02:58:35 +0000 Original-Received: from localhost ([127.0.0.1]:54004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSwzz-0000YS-Ex for submit@debbugs.gnu.org; Wed, 05 Jul 2017 22:58:35 -0400 Original-Received: from mail-it0-f51.google.com ([209.85.214.51]:38708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSwzx-0000YB-PR; Wed, 05 Jul 2017 22:58:34 -0400 Original-Received: by mail-it0-f51.google.com with SMTP id k192so104546029ith.1; Wed, 05 Jul 2017 19:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=aY+As/l+JK2oxKMMvb/JIRJtFmT9cYwNskndwAag8z0=; b=Y0pGcPEyBvM6/4mu4LF2eUftBstuF5n3/JvCETNPvBwk7rCQFNJY10Xv7GbjRmXQoa G1M1UuwW3PDSlR76yh5uI/D6sZThomfkdHg+UWps9o+baLDMxqOTgqYjM/Nin9I6fRgE X0QonXOMrpoSQAawzAuTockWWUfgnh36Jvymy+wBJ4AVgA3hXWTx8sQXsvQUsVvaQRul y8vz3VOAHYWIkas/RkGJXc2Lc5a40GVR+yD3WoHrAx1Xo4tH2WVDh9h12+9lQkxXE4iI AtnHHOvFYGVj6fbfSelHoR5uwbufMRdzk5Husa8NkwzauKMZ+KYrEoWhDS6B5tbevypO 2YSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=aY+As/l+JK2oxKMMvb/JIRJtFmT9cYwNskndwAag8z0=; b=iYyAZz8kFpvEjcg7MDw/XWkdLCGCBu/2gbnj/gMiPEQREpqI1c2QewDngX+GKNX3RI MUcSSanlekfWwCEkmExUHlvRB7IL6EcPhw4naVmm72MFUvkPsxPSRACWlxa/p2pRrEpW kOAG2GPuDMPfUn9ESE0G8nxkVPyxEKyPNXTYTSorleR3BO+2NnsmfdmB9QudzNbz9sS9 mcshB6f0t8D3BlP+k33NxAD0jm7fXGBc4UVgdUzSqR9j9xpBONEeeWJDQblN2UQ4/klY lngR45yrqcMVD/fif5+9Mr3Psvl5GbwLk34rK8ZjeZ3zkiyMd7X4MZlQ/UfgW+FwWrg+ xgfg== X-Gm-Message-State: AKS2vOzcFkL0EeYKkrJwH9KVHqBCns+iufGg2TqEpVwbA4S2mYSI9UhF 2hw58IlgVSPPiKkb X-Received: by 10.107.201.66 with SMTP id z63mr46758883iof.220.1499309908188; Wed, 05 Jul 2017 19:58:28 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id s135sm13963399ita.2.2017.07.05.19.58.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Jul 2017 19:58:27 -0700 (PDT) In-Reply-To: <878tkut9b3.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Wed, 14 Jun 2017 19:54:08 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134238 Archived-At: tags 19740 fixed close 19740 26.1 quit npostavs@users.sourceforge.net writes: >> This is a regression introduced after Emacs 20 (perhaps after 21). >> >> Emacs should not indent the first `;;' comment line here by a space. >> That does no good and interferes with alignment of a multi-line >> comments and multiple separate comments that are on the same level. >> >> (let* ( ;; If FOOBAR then blah the blahdy blah and other blahs if blah, >> ;; blah, or blah. Unless, that is, blah, blah, or blah. >> (the-tatas (bar-bar-toto-babar foo1 foo2 foo3)) >> ...) >> >> In Emacs 20, this is the result - no extra space inserted. The two >> comment lines, which are logically at the same level, and in this case >> are part of a single multi-line comment, are aligned vertically. >> >> (let* (;; If FOOBAR then blah the blahdy blah and other blahs if blah, >> ;; blah, or blah. Unless, that is, blah, blah, or blah. >> (the-tatas (bar-bar-toto-babar foo1 foo2 foo3)) >> ...) > > > This was introduced in [1: bdbe3a8995]. I think in most contexts, it > makes sense to put the space, but it definitely looks wrong in a lisp > let. Here's patch to override the alignment for comments following an > open in paren in lisp modes. Pushed: [2: 7a0170de20] [2: 7a0170de20]: 2017-07-05 22:52:36 -0400 Don't put whitespace between open paren and comment in Lisp modes (Bug#19740) http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=7a0170de20fe1225d3eeac099d1e61a0c0410bf3