From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#5615: 23.1.92; [PATCH] term.el: Calculation of window height is bad (new patch) Date: Sat, 19 Aug 2017 23:34:24 -0400 Message-ID: <87lgmeyksf.fsf@users.sourceforge.net> References: <4B80CB5A.8080306@yahoo.co.jp> <4BA35102.7050506@yahoo.co.jp> <87oab1tlku.fsf@gnus.org> <87bmnn2aqr.fsf@users.sourceforge.net> <834ltesjg4.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1503199999 5186 195.159.176.226 (20 Aug 2017 03:33:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 20 Aug 2017 03:33:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: larsi@gnus.org, irieshinsuke@yahoo.co.jp, 5615@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 20 05:33:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djGz6-0000pM-N7 for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Aug 2017 05:33:08 +0200 Original-Received: from localhost ([::1]:42613 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djGzD-0004R1-HN for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Aug 2017 23:33:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djGz3-0004PP-8r for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2017 23:33:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djGz0-0002T3-5K for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2017 23:33:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37315) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1djGz0-0002Sx-1P for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2017 23:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1djGyz-00044O-On for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2017 23:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Aug 2017 03:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5615 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 5615-submit@debbugs.gnu.org id=B5615.150319997715634 (code B ref 5615); Sun, 20 Aug 2017 03:33:01 +0000 Original-Received: (at 5615) by debbugs.gnu.org; 20 Aug 2017 03:32:57 +0000 Original-Received: from localhost ([127.0.0.1]:45996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djGyu-000440-Ce for submit@debbugs.gnu.org; Sat, 19 Aug 2017 23:32:56 -0400 Original-Received: from mail-it0-f66.google.com ([209.85.214.66]:38380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djGys-00043i-AR; Sat, 19 Aug 2017 23:32:54 -0400 Original-Received: by mail-it0-f66.google.com with SMTP id w204so247931ita.5; Sat, 19 Aug 2017 20:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Y2SBvPTI1q5InWJICYm6xweiUx98jJn3VWriomS77lY=; b=AlqBSBC4mVxDKYJTC7M3gTcIUJC0udFPX6xCqCW9zJfuIlo2+0OGIbZkkoLugj918Y ttV89m/7h2lwVoh8D1gK4cNV0bcrO5aYwoVa/hjqoNorCD7T14ER852R6htk5c1Ewk9Z fDRnqHqcNr/tPbqe3mw355j4d55BI6/nn2XpWtgXLboljGAh9hpmYVQRQNdKRPyXNxu4 Jr8sGLuRVqNwPs8W4+cAv52CQeIHNiN5U33E133b4bK6YLBkqM18Ci0+vyPeBYF87l46 UYdq3StBQ16q3qW1bjwjxzB9cbUoo/9ku6YukVOqNBRtA0mH2zZrSNfidIjdJY+0pcn9 KSwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=Y2SBvPTI1q5InWJICYm6xweiUx98jJn3VWriomS77lY=; b=tL31Mh1XTnwrnHif/gNKu06ni4npo+4IGc6HJUINk0+5pNEzZDSsKhSToqRb9v/X5L G3z7tOHuhXYpenRww3l1j4fLHZJtTOvJdDC8tIGuw8dkuiSww2A9rmvFYwZg/l33itlL uzIukeIIS211Dvl2IPTz19/zeuxRlMSDWUexH0wR76AC2A6Uy3sCG6DIPta1eD2WfIpQ HXhzAwZW/BJH5/aN0fN8fpTITHCpQtoiXF4A2ZJaU0fNrhHCnN9dgaTv82jZO8f2QBlR Lv3KUlqb6BUaxz7O8h+kUR7XAGfu+Bzmhqr1fCEF/+CAySNJ3fq7MMUJzU0sE+avs03n Q9Zw== X-Gm-Message-State: AHYfb5hFhvqXoXVYPZPqO2/t7MvjGl9WTh0rjAG+/MTdbaurwuwMsNAM gXaJCLJuMkR8QRnk X-Received: by 10.36.77.136 with SMTP id l130mr2435600itb.67.1503199968605; Sat, 19 Aug 2017 20:32:48 -0700 (PDT) Original-Received: from zony ([45.2.119.49]) by smtp.googlemail.com with ESMTPSA id z139sm2493089itb.41.2017.08.19.20.32.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 19 Aug 2017 20:32:47 -0700 (PDT) In-Reply-To: <834ltesjg4.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Aug 2017 09:32:43 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135929 Archived-At: tags 5615 fixed close 5615 26.1 quit Eli Zaretskii writes: >> From: npostavs@users.sourceforge.net >> Date: Thu, 10 Aug 2017 20:45:16 -0400 >> Cc: IRIE Shinsuke , 5615@debbugs.gnu.org >> >> Current Emacs still uses the same (1- (window-height)) expression, but I >> can't understand from the description when exactly this gives the wrong >> result. Furthermore, I don't see any justification which would explain >> why the new proposed significantly more complicated computation is more >> correct. I think we should just use window-text-height. > > I think you are right. If no one objects in a few days, please push > your change. Pushed to master. [1: dbd3a17cb0]: 2017-08-19 23:29:28 -0400 * lisp/term.el (term-mode): Use `window-text-height' (Bug#5615). http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=dbd3a17cb068148bd49e288eb0b44ca7eb4a4e3c