From: npostavs@users.sourceforge.net
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, irieshinsuke@yahoo.co.jp, 5615@debbugs.gnu.org
Subject: bug#5615: 23.1.92; [PATCH] term.el: Calculation of window height is bad (new patch)
Date: Sat, 19 Aug 2017 23:34:24 -0400 [thread overview]
Message-ID: <87lgmeyksf.fsf@users.sourceforge.net> (raw)
In-Reply-To: <834ltesjg4.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Aug 2017 09:32:43 +0300")
tags 5615 fixed
close 5615 26.1
quit
Eli Zaretskii <eliz@gnu.org> writes:
>> From: npostavs@users.sourceforge.net
>> Date: Thu, 10 Aug 2017 20:45:16 -0400
>> Cc: IRIE Shinsuke <irieshinsuke@yahoo.co.jp>, 5615@debbugs.gnu.org
>>
>> Current Emacs still uses the same (1- (window-height)) expression, but I
>> can't understand from the description when exactly this gives the wrong
>> result. Furthermore, I don't see any justification which would explain
>> why the new proposed significantly more complicated computation is more
>> correct. I think we should just use window-text-height.
>
> I think you are right. If no one objects in a few days, please push
> your change.
Pushed to master.
[1: dbd3a17cb0]: 2017-08-19 23:29:28 -0400
* lisp/term.el (term-mode): Use `window-text-height' (Bug#5615).
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=dbd3a17cb068148bd49e288eb0b44ca7eb4a4e3c
next prev parent reply other threads:[~2017-08-20 3:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4B80CB5A.8080306@yahoo.co.jp>
2010-03-19 10:23 ` bug#5615: 23.1.92; [PATCH] term.el: Calculation of window height is bad (new patch) IRIE Shinsuke
2010-03-19 10:25 ` IRIE Shinsuke
2016-02-28 6:06 ` Lars Ingebrigtsen
2017-08-11 0:45 ` npostavs
2017-08-11 6:32 ` Eli Zaretskii
2017-08-20 3:34 ` npostavs [this message]
2010-03-19 10:38 ` IRIE Shinsuke
2010-05-30 5:23 ` Ken Hori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgmeyksf.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=5615@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=irieshinsuke@yahoo.co.jp \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.