From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#28043: [PATCH] Optimize skkdic conversion Date: Mon, 21 Aug 2017 20:54:50 -0400 Message-ID: <87lgmcbew5.fsf@users.sourceforge.net> References: <87r2wi23c2.fsf@users.sourceforge.net> <831soisj5i.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1503363253 8750 195.159.176.226 (22 Aug 2017 00:54:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 22 Aug 2017 00:54:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 28043@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 22 02:54:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djxSK-00020I-HF for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Aug 2017 02:54:08 +0200 Original-Received: from localhost ([::1]:45964 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djxSR-0002aS-DS for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Aug 2017 20:54:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djxSH-0002Yl-RW for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2017 20:54:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djxSE-0002DZ-Lo for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2017 20:54:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39696) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1djxSE-0002DR-I2 for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2017 20:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1djxSE-0007xz-BI for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2017 20:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Aug 2017 00:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28043 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28043-submit@debbugs.gnu.org id=B28043.150336319930564 (code B ref 28043); Tue, 22 Aug 2017 00:54:02 +0000 Original-Received: (at 28043) by debbugs.gnu.org; 22 Aug 2017 00:53:19 +0000 Original-Received: from localhost ([127.0.0.1]:48377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djxRX-0007wp-L3 for submit@debbugs.gnu.org; Mon, 21 Aug 2017 20:53:19 -0400 Original-Received: from mail-it0-f67.google.com ([209.85.214.67]:34629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djxRW-0007wa-4J; Mon, 21 Aug 2017 20:53:18 -0400 Original-Received: by mail-it0-f67.google.com with SMTP id s132so10817260ita.1; Mon, 21 Aug 2017 17:53:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Pp3YPuv3dgUsObJ4CuM7w76UaVnxXgeI1BnXqPQaFU0=; b=igmdFzdchnGp6Cv+JK2+YI+e4pH7naZbAvT7zL2dwTYo0XeTR8HQSwaAZecxkmWlF4 Jt5LOprxLG8aBkMZGKLuWsPxY/2hxAIpEQzrfJPBXxU6iyD7mCW51Q55RE07+1RmCb5n SAScPRud185TunHtWllx4KExkOVJ6vfIZExq22FgSKwyDdqaHLOcQjHyP+HBa7HIeMLw bcJ9DWx2JFTePviD7CGg0OwWxHRaDUljtd+XJBMZOi7T9meGSIPIBY3jrSvg/eBrhcQK rq5rfPvea+XlhShGXwyljEWHqLlE7Ir0Y/RqJBmQFV1xGi3okS0Z8DhrESd0VX3JATLa WRKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=Pp3YPuv3dgUsObJ4CuM7w76UaVnxXgeI1BnXqPQaFU0=; b=XPRc8NT7OE+zdz78SZULcUPPQ5SwQq70ae4pdJnRLtVk1+hj8zkXHoqZS4fwuBfshr 8QwQpHKk+zc3IcY1IpTMXAayYR+OtSfNoFlHC810bBIsntTAZGbEJZHygkwWKn8xCw8B lnR/EgUUOMT5M9SOTxTcGA9YnyquEEXkouFB1Yc+2iU7cRCKI5ftYNUJ6bapZU12sMqY /J0AkG4uKchCSmfIdlHL04/dhJYCiMSW1qBpZivK9GnG1T7oq+3Y3byLmtuK4NM+4XXS gESvE6GIoGDzy1hQ6taesoBKmOLpDp1rvCrapL3IlmcLGU+2zux153X+nR1Wxe1JqDpV qW0Q== X-Gm-Message-State: AHYfb5hcy3j9q+NRZbSHzs3sOCje6nBdHQajGKvT2oLPL5NktCievrsa DBZa8ysQwLWiKXrt X-Received: by 10.36.161.14 with SMTP id y14mr2146243ite.181.1503363192315; Mon, 21 Aug 2017 17:53:12 -0700 (PDT) Original-Received: from zony ([45.2.119.49]) by smtp.googlemail.com with ESMTPSA id f11sm575126itf.1.2017.08.21.17.53.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Aug 2017 17:53:11 -0700 (PDT) In-Reply-To: <831soisj5i.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Aug 2017 09:39:05 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136031 Archived-At: tags 28043 fixed close 28043 26.1 quit Eli Zaretskii writes: >> From: npostavs@users.sourceforge.net >> Date: Thu, 10 Aug 2017 23:25:17 -0400 >> >> While waiting for a bootstrap, I thought the skkdic conversion was >> looking a bit slow. The following patches reduce the time needed to >> less than a third of the original (2m30 to 45s measured using a >> non-optimized Emacs). The main speedup comes from optimizing >> lookup-nest-alist and set-nested-alist for the case where the key is a >> string. I suspect it might be possible to optimize even more by >> reorganizing things, but my ignorance of Japanese makes that difficult. >> >> Each commit message has the time I measured after applying. I checked >> that the generated ja-dic.el is identical to what was generated before. > > Thanks. CC'ing Handa-san, who could perhaps suggest more > optimizations. > > I guess you've verified that the results are identical after these > optimizations? If so, I see no reason not to push in a few days. Okay, I've pushed to master. [1: 9d7973530f]: 2017-08-21 20:52:25 -0400 Optimize skkdic conversion (Bug#28043) http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9d7973530f912c6001445ba9b83b7893b466aee8