From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 29303@debbugs.gnu.org, gus@inodes.org
Subject: bug#29303: 25.2; vc-git-grep should shell-escape FILES
Date: Wed, 15 Nov 2017 21:36:09 +0100 [thread overview]
Message-ID: <87lgj7nuti.fsf@gmail.com> (raw)
In-Reply-To: <83y3n7i90b.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 15 Nov 2017 22:26:12 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: 29303@debbugs.gnu.org, gus@inodes.org
>> Date: Wed, 15 Nov 2017 21:17:35 +0100
>>
>> > That's okay portability-wise, but why do you need split-string?
>> > AFAIU, grep-read-files reads a single pattern, no?
>>
>> grep-read-files has support for grep-files-aliases which allows you to
>> eg say 'cc' and have it expand to "*.cc *.cxx *.cpp *.C *.CC *.c++"
>
> Ah. So we lose support of patterns with embedded whitespace in order
> to support the aliases? Is that desirable?
That's a good question. Note that interactively entering patterns with
a space is currently a pain, since grep-read-files uses
read-file-name-internal, which attempts to do completion if you type
<SPC>. So this would presumably only affect people who have changed
grep-files-aliases and have patterns with embedded whitespace.
Robert
next prev parent reply other threads:[~2017-11-15 20:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 6:25 bug#29303: 25.2; vc-git-grep should shell-escape FILES Angus Lees
2017-11-15 9:58 ` Robert Pluim
2017-11-15 17:42 ` Eli Zaretskii
2017-11-15 18:45 ` Robert Pluim
2017-11-15 19:58 ` Eli Zaretskii
2017-11-15 20:17 ` Robert Pluim
2017-11-15 20:26 ` Eli Zaretskii
2017-11-15 20:36 ` Robert Pluim [this message]
2017-11-16 15:38 ` Eli Zaretskii
2017-11-16 15:43 ` Robert Pluim
2017-11-17 7:13 ` Angus Lees
2017-11-17 8:38 ` Robert Pluim
2017-11-17 9:06 ` Eli Zaretskii
2017-11-17 9:54 ` Robert Pluim
2017-11-17 10:13 ` Eli Zaretskii
2017-11-17 10:33 ` Robert Pluim
2017-11-17 13:41 ` Eli Zaretskii
2017-11-17 14:21 ` Robert Pluim
2017-11-28 13:37 ` Robert Pluim
2017-11-28 17:49 ` Eli Zaretskii
2017-11-16 15:55 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgj7nuti.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=29303@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=gus@inodes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.