From: "Simen Heggestøyl" <simenheg@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 29456@debbugs.gnu.org, tom@tromey.com, monnier@iro.umontreal.ca
Subject: bug#29456: [PATCH] Add command for cycling between CSS color formats
Date: Tue, 28 Nov 2017 19:33:30 +0100 [thread overview]
Message-ID: <87lgiqmex1.fsf@gmail.com> (raw)
In-Reply-To: <83bmjn5zr9.fsf@gnu.org> (message from Eli Zaretskii on Mon, 27 Nov 2017 20:43:06 +0200)
Tom Tromey <tom@tromey.com> writes:
> Nice feature!
Glad you like it!
> It seems to me that none of the functions handle alpha components.
> css-color-4 added optional alpha to hex colors (and made rgb and rgba
> synonyms), and there's been rgba for a while...
Right, it makes sense to support that too. I haven't used alpha formats
other than rgba(...) myself. Would it be useful for rgba(255, 0, 0, 0.5)
to turn into #ff000088, for instance?
Eli Zaretskii <eliz@gnu.org> writes:
> Then I think there should be a prominent remark in the doc strings of
> css-mode not to mix these functions with those from color.el, due to
> this incompatibility.
That sounds like a good idea.
I'll address the comments from both of you in an update to the patch,
though it might be a while until I have the time to update it.
Thanks for your comments so far.
-- Simen
next prev parent reply other threads:[~2017-11-28 18:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-26 15:21 bug#29456: [PATCH] Add command for cycling between CSS color formats Simen Heggestøyl
2017-11-26 17:53 ` Tom Tromey
2017-11-27 17:07 ` Eli Zaretskii
2017-11-27 17:41 ` Tom Tromey
2017-11-27 18:11 ` Eli Zaretskii
2017-11-27 18:35 ` Tom Tromey
2017-11-27 18:43 ` Eli Zaretskii
2017-11-28 18:33 ` Simen Heggestøyl [this message]
2017-11-28 20:57 ` Simen Heggestøyl
2017-12-10 12:46 ` Simen Heggestøyl
2017-12-10 18:09 ` Eli Zaretskii
2017-12-17 9:32 ` Simen Heggestøyl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgiqmex1.fsf@gmail.com \
--to=simenheg@gmail.com \
--cc=29456@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.