From: Noam Postavsky <npostavs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 30481@debbugs.gnu.org
Subject: bug#30481: 26.0.91; infinite recursion + edebug = memory corruption
Date: Fri, 16 Feb 2018 22:30:33 -0500 [thread overview]
Message-ID: <87lgfs70o6.fsf@gmail.com> (raw)
In-Reply-To: <83k1vde3bn.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 16 Feb 2018 10:39:08 +0200")
tags 30481 fixed
close 30481 26.1
quit
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Noam Postavsky <npostavs@gmail.com>
>> Date: Thu, 15 Feb 2018 22:38:10 -0500
>>
>> The following patch solves the problem by not calling
>> signal-hook-function when the specpdl array is exhausted. I think it
>> could be safe for emacs-26.
>
> Please push to emacs-26, and thanks.
Pushed (with test) [1: c352434ab8].
> (Is it practical to have a test for this?)
Yes, actually. I initially had some trouble reproducing without
instrumenting a function with edebug, but now I see that's just because
a function which let-binds only a single variable hits
max-lisp-eval-depth before max-specpdl-size (edebug's intrumentation
adds more bindings per call). Let-binding two variables allows to
trigger the bug with just
(defun foo ()
(let ((x 1)
(y 2))
(foo)))
(let ((signal-hook-function #'ignore))
(foo))
[1: c352434ab8]: 2018-02-16 22:13:34 -0500
Avoid memory corruption with specpdl overflow + edebug (Bug#30481)
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c352434ab89617b48c7c1f29342a22e5a5685504
prev parent reply other threads:[~2018-02-17 3:30 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 22:12 bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames phst
2018-01-24 22:43 ` Philipp Stephani
2018-01-24 23:04 ` Noam Postavsky
2018-01-24 23:25 ` Philipp Stephani
2018-01-25 5:57 ` Noam Postavsky
2018-01-25 9:49 ` Michael Albinus
2018-01-25 14:07 ` Noam Postavsky
2018-01-25 16:36 ` Michael Albinus
2018-01-25 16:46 ` Noam Postavsky
2018-01-26 1:46 ` Noam Postavsky
2018-01-26 11:01 ` Michael Albinus
2018-01-26 22:11 ` Noam Postavsky
2018-01-28 10:28 ` Michael Albinus
2018-01-28 14:58 ` Noam Postavsky
2018-01-28 19:17 ` Michael Albinus
2018-01-30 13:46 ` Eli Zaretskii
2018-01-30 16:02 ` Michael Albinus
2018-01-30 19:22 ` Philipp Stephani
2018-01-31 0:01 ` Noam Postavsky
2018-01-31 16:02 ` Eli Zaretskii
2018-01-31 18:07 ` Michael Albinus
2018-01-31 18:16 ` Noam Postavsky
2018-01-31 18:21 ` Michael Albinus
2018-02-01 14:01 ` Michael Albinus
2018-02-01 16:40 ` Philipp Stephani
2018-02-01 18:52 ` Michael Albinus
2018-02-02 1:16 ` Noam Postavsky
2018-02-02 17:56 ` Michael Albinus
2018-02-03 20:34 ` Noam Postavsky
2018-01-31 15:38 ` Eli Zaretskii
2018-02-16 3:38 ` bug#30481: 26.0.91; infinite recursion + edebug = memory corruption Noam Postavsky
2018-02-16 8:39 ` Eli Zaretskii
2018-02-17 3:30 ` Noam Postavsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgfs70o6.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=30481@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.