From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29156: 25.3; eshell/kill does not understand -, [PATCH] Make eshell/kill handle - and - Date: Fri, 16 Mar 2018 20:34:25 -0400 Message-ID: <87lgerv8tq.fsf@gmail.com> References: <87vaiprmg5.fsf@gmail.com> <87o9jnv9et.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1521246794 10169 195.159.176.226 (17 Mar 2018 00:33:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Mar 2018 00:33:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: Eric Skoglund , Pierre Neidhardt To: 29156@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 17 01:33:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewzmW-0002Yp-3k for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Mar 2018 01:33:08 +0100 Original-Received: from localhost ([::1]:60143 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewzoZ-0005oH-97 for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Mar 2018 20:35:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewzoP-0005oA-Nk for bug-gnu-emacs@gnu.org; Fri, 16 Mar 2018 20:35:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewzoM-0005eP-K8 for bug-gnu-emacs@gnu.org; Fri, 16 Mar 2018 20:35:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57763) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ewzoM-0005e0-GO for bug-gnu-emacs@gnu.org; Fri, 16 Mar 2018 20:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ewzoM-0000vK-86 for bug-gnu-emacs@gnu.org; Fri, 16 Mar 2018 20:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Mar 2018 00:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29156 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed easy Original-Received: via spool by 29156-submit@debbugs.gnu.org id=B29156.15212468753505 (code B ref 29156); Sat, 17 Mar 2018 00:35:02 +0000 Original-Received: (at 29156) by debbugs.gnu.org; 17 Mar 2018 00:34:35 +0000 Original-Received: from localhost ([127.0.0.1]:37427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewznu-0000uT-RM for submit@debbugs.gnu.org; Fri, 16 Mar 2018 20:34:35 -0400 Original-Received: from mail-it0-f53.google.com ([209.85.214.53]:50667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewzns-0000uD-QH for 29156@debbugs.gnu.org; Fri, 16 Mar 2018 20:34:33 -0400 Original-Received: by mail-it0-f53.google.com with SMTP id d13-v6so4093767itf.0 for <29156@debbugs.gnu.org>; Fri, 16 Mar 2018 17:34:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=TOc8Ej1tab6AQrfSb8Q8qhutqZq7v9bZHM1QkKb3SzQ=; b=WpzsCeyJTBuFWbOtU8hR3JgVax6x/d/zwboz6aFEg3JkXpKkUO7o0BYVZksW02YSV1 dvolkDsz0sg62cqVTvUIBwgVT5xzHn/p4DPHHYCXX6c1SPZ6xqi79B7+0oC11V4htr+E DeonjMjgnpzvcVIAncuc4Fk37eo0/ZgClWBZcVVzrDxrol7j7U6zDJGaidI85tAixvTV fFiE4BtsKsCsft0jWHjyEb6sVwlvZtoIyESbBrsIwZpxb3KpjIaROMaKgXj3RVq/RAaw sOsKdDMEnqcVEjT5qiS/fJ7i2tElktoTL1VISSwBvmTplgrK0ImQx+r2EgF844a8k7IN O5OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=TOc8Ej1tab6AQrfSb8Q8qhutqZq7v9bZHM1QkKb3SzQ=; b=UmPCOAOMVePBvGePift+eWi4GEXcg/CGmVV3srmR3uWFWsLdLY19oYgLKtE2msBw91 TTFB3sDukhpTfACG8Yt799S8hDP8mSmd7TDtratc5TXQxsCSmshpWS3jMJXA06ouHqxt k0q11Yo1YfBg1Kc5Tx33hggpKX1q/dgogNxXh9IGn0X6fnhAmt7NSTySAbY2ncg24QF2 eRcLX85KC+Uv7aIyoWp9vW/QAaOUc16cfYnP2czdCv7kZ2Kn2GsgwG4I0ajWHGxjwF06 H0k6mAcqYT7v8FXfyL1d0pxQ3CzmsvuoupSC6Xa1EM8FxVaiRhWCp2QrKuy17gkqyfM5 jI6g== X-Gm-Message-State: AElRT7HNDUm9UreeBkD9VQOqlIJWcBnn0Jvns4pAfnTUXlMUQ1jbxlHk Y7BKiUEyvp9KSSctrMwXCBA= X-Google-Smtp-Source: AG47ELtzRrrzCXJ8I/ODJXu1/t80IYKM9Pd6fRl/4HAY31uxRl4VaNoUVW3FUC1feQAWxl/1iY6s+w== X-Received: by 2002:a24:8c:: with SMTP id 134-v6mr4523918ita.70.1521246867130; Fri, 16 Mar 2018 17:34:27 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 199-v6sm2041683itl.1.2018.03.16.17.34.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Mar 2018 17:34:26 -0700 (PDT) In-Reply-To: <87o9jnv9et.fsf@gmail.com> (Noam Postavsky's message of "Fri, 16 Mar 2018 20:21:46 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144350 Archived-At: > From: Eric Skoglund > First time contributor. Here's a patch that allows eshell/kill to handle > both the -9 case and the -SIGKILL case. Thanks! > * lisp/eshell/esh-proc.el: Handle - and - Minor formatting nitpick, you should have the function name here: * lisp/eshell/esh-proc.el (eshell-kill): ... More importantly, could you explain a bit how your change works/why it's correct? > ((string-match "\\`-\\([[:upper:]]+\\|[[:lower:]]+\\)\\'" arg) > - (setq signum (abs (string-to-number arg))))) > + (setq signum (make-symbol (substring arg 1 (length arg)))))) Not sure this `make-symbol' call, should it rather be `intern'? (Maybe we should update signal-process take a string as well a symbol.) > (setq args (cdr args)))) > (while args > (let ((arg (if (eshell-processp (car args)) > (process-id (car args)) > - (car args)))) > + (string-to-number (car args))))) I think the args have already been converted to numbers, or did you mean to also add a (put 'eshell/kill 'eshell-no-numeric-conversions t)?