From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 51c8369: Run secrets suite test when Emacs has dbus support Date: Fri, 06 Apr 2018 09:25:22 +0200 Message-ID: <87lge07q59.fsf@gmx.de> References: <20180406000306.5540.34428@vcs0.savannah.gnu.org> <20180406000308.94E77206AB@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1522999454 4973 195.159.176.226 (6 Apr 2018 07:24:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Apr 2018 07:24:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Tino Calancha To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 06 09:24:10 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f4LjB-00012g-10 for ged-emacs-devel@m.gmane.org; Fri, 06 Apr 2018 09:24:05 +0200 Original-Received: from localhost ([::1]:60403 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4LlE-0001dN-Nq for ged-emacs-devel@m.gmane.org; Fri, 06 Apr 2018 03:26:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4Lka-0001d2-8G for emacs-devel@gnu.org; Fri, 06 Apr 2018 03:25:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f4LkV-0005yM-B1 for emacs-devel@gnu.org; Fri, 06 Apr 2018 03:25:32 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:46181) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f4LkU-0005xm-VN for emacs-devel@gnu.org; Fri, 06 Apr 2018 03:25:27 -0400 Original-Received: from detlef.gmx.de ([212.86.63.48]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LoE4f-1ebdm63FlJ-00gFRy; Fri, 06 Apr 2018 09:25:23 +0200 In-Reply-To: <20180406000308.94E77206AB@vcs0.savannah.gnu.org> (Tino Calancha's message of "Thu, 5 Apr 2018 20:03:07 -0400 (EDT)") X-Provags-ID: V03:K1:Bnx1NnkyLpLpAI4HR1fMx/TxO180Ex43iQMKOTsU8fvbaOyqmEE +LAiuq6LJPUNCbtbZTpFkcGaxjXXs67m97m6g2YHCZlexgPflI9If6duvhFKLuC3V8cdGqM Sn6Y8V/DSHom7vEoP6gPSWCFBl64d01SkhI3PlqpCxmUq1XhcsjJgxypBjb692qaV/F0xyK bjWNci174bFLWqP3P15HQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:49VMIDvqtzk=:hwewLPuQHEBw3IxoTbpQnt uy0d3ZohpVnf40OKORO2nCdURr7l9D1UzQ9mbjIAy6ApIlGyAggwbJ9rCAIU+3a1qv+dNL4f7 tysiYAW+3QZ3b6ybFazdwEDn946xo5aAQxIjNx7CfXjhqtiVbtOkZjztdtJhzYpemadV1N4CJ rvENIrnxS6ELIiwVyuyBhmvQ9itOtZ/m25wi+weiFS6Tw1Ni1A2Hu97enzni67YLlCHzThb/m VQdbxA9XijMYlBigkpjR34FYn+Iug2gThe5yZY0ekvH48QEi6Pqf/6RKNS0r6NZ6aGczO1ZCT tb5Q4AlGw3AvmgPdUlEnJ4r7xB+PajQ+vS9H7VJYEJUhKfTNeY5W/pM5PJ36+ai1MKSa4W8O9 IXQZdPkf3kUmPc6H5tSX11KhXkCq5B6+bQG+HpMRchR/fNHlwCG8gD19UYc4p/z1c7wgnST79 JDNnqYemFB98ocah0WO6Pyjuvy7FBL62hbq58gq3eAJnoPSektBsB5ICxp3abGS7UOrAGWBco JD1qSMIZ5IBgILrLq+8woSEiAEThaUJSTKtZTgD49PbRD7NUzuW036XnwAU9BfJF/FSkWRFLZ EdEFZ4O2N28tL0tJ6VEg478YFVcc4+OZZwcLpnvtri/y2upzPX4Dh6sgySe0VNej1CA0EBpP4 UNiJ4iYiunOD7mTte/QIn8oySijwWQou3YU1w5lDNZiAR1F2JhwNTo9ERZ0dFZVP4/P8dOaw/ DkUCE6sDIm6q2WpMrFkYxM3WmZVXK9o6CqebfUGgy4gclI/MJH6AR9ayMIFmOecc7MI6BzQL X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.15.18 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224391 Archived-At: tino.calancha@gmail.com (Tino Calancha) writes: Hi Tino, > Run secrets suite test when Emacs has dbus support > > * test/lisp/net/secrets-tests.el (secrets-test00-availability) > (secrets-test01-sessions, secrets-test02-collections) > (secrets-test03-items, secrets-test04-search): Skip test > unless Emacs is compiled with dbus support. Why this? If there is no D-Bus support, secrets-enabled shall be nil, and the tests shall skip (except secrets-test00-availability, which shall fail). That's intended. > (ert-deftest secrets-test00-availability () > "Test availability of Secret Service API." > + (skip-unless (featurep 'dbusbind)) > :expected-result (if secrets-enabled :passed :failed) > (should secrets-enabled) > (should (dbus-ping :session secrets-service)) FTR, this would be wrong. :expected-result must always be the first clause in body. Best regards, Michael.