From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: package.el strings Date: Wed, 25 Apr 2018 21:10:05 -0400 Message-ID: <87lgdarcwi.fsf@gmail.com> References: <83y3rpeubc.fsf@gnu.org> <07C02D08-66BB-4454-AA25-B512BFC39A2A@gmail.com> <83vamk965y.fsf@gnu.org> <84FCCBF3-F20F-48E2-B05E-F6DB218D8896@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1524704896 5913 195.159.176.226 (26 Apr 2018 01:08:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 26 Apr 2018 01:08:16 +0000 (UTC) Cc: Emacs developers To: Jean-Christophe Helary Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 26 03:08:12 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fBVON-0001RL-BB for ged-emacs-devel@m.gmane.org; Thu, 26 Apr 2018 03:08:11 +0200 Original-Received: from localhost ([::1]:39824 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBVQS-0004OQ-B1 for ged-emacs-devel@m.gmane.org; Wed, 25 Apr 2018 21:10:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37470) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBVQM-0004OK-67 for emacs-devel@gnu.org; Wed, 25 Apr 2018 21:10:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fBVQH-0004N7-2v for emacs-devel@gnu.org; Wed, 25 Apr 2018 21:10:14 -0400 Original-Received: from mail-io0-x234.google.com ([2607:f8b0:4001:c06::234]:38048) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fBVQG-0004Mp-Sa for emacs-devel@gnu.org; Wed, 25 Apr 2018 21:10:08 -0400 Original-Received: by mail-io0-x234.google.com with SMTP id z4-v6so5391844iof.5 for ; Wed, 25 Apr 2018 18:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=DD3iFIDNfgQGoe+3sfzo2fBp1IvdsKmUo1v9Ky5E8mo=; b=tFMuI8pXubchE8Y4Rogx3+ZY3UFLRgQ50MqG7zJr5xh8YyIDuseIvFKDX/QbtjhU0D tskIia/DQGQeBJHLh+T3OzrGJqU755N9/9DjEXMGhVPO5BPt45uZnKvkIyaR7KGvkj8K J1Yhu6IHZJeyFdKKXKaWcT7Id9x8GsZA5GupgNIt8zw9nlVSz6DOmDDy/V9wuyFbzMbW JG97STWj63mkZC8x4BnmZ0q0ss4/QQjOy+joBXirJElyV5d+QGgWqFA6U4U9Ef5XUhCz OdYkYqNTxqTU2KUYUOqcEmz03LHS7g1cE1EvTZCJKyovhx+RcEI6oWG6H0dk3oA7gNpD ksiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=DD3iFIDNfgQGoe+3sfzo2fBp1IvdsKmUo1v9Ky5E8mo=; b=dkOij9hUiHJhMVFu9Bf1i+zfDriouLL6P4OEqP+ytJjguGAaKrdgRqqVjx8pco5zf8 IUk18Rjndb5Q0NRRa1Bk9p+1ectcW301wwsBPStcd2w3aUQKPXU9ABmZiky/Q0oH1hTZ wppLDQJr8B0JwN0s37HYQI2ZadiNxYnDm2G9xbAgfYC1fG3L2Fz1AcNwn0240ev2ZUxb jvXM8dZl79o4/jvLdMvs/fe5XpWE9NGxwFa8zyKxOtgTYBhnuMfA3c/Cn5eIEwzMfmi7 tL8gwyELesVb9gIb8ujKFXVjAbX2cx2fgkSLZzGAoEWkCSsRrTFN38706FJOGqOB5/KA 12MA== X-Gm-Message-State: ALQs6tDGsZYAbQUQuig4SY8I+TSOvbYCz5vBGqpRn2Zyc9bdsfYDntMk Ogow4tMmdfg/ocGWxGL0biHZ4g== X-Google-Smtp-Source: AB8JxZqb/7xUawUBEuTrWuSQHGM8jeUpS7s5ynp3Iu5jHxutteeGhIsAFptlx9BACJG11DQ6zSjjRA== X-Received: by 2002:a6b:93c6:: with SMTP id v189-v6mr32350712iod.84.1524705008065; Wed, 25 Apr 2018 18:10:08 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id d7-v6sm973205itf.10.2018.04.25.18.10.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Apr 2018 18:10:06 -0700 (PDT) In-Reply-To: <84FCCBF3-F20F-48E2-B05E-F6DB218D8896@gmail.com> (Jean-Christophe Helary's message of "Wed, 18 Apr 2018 15:38:26 +0900") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4001:c06::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224895 Archived-At: > Almost 9 months and nothing in master. Was there anything wrong with > the code? I think the problem is more a lack of people who "make changes in package.el". Although there's enough that your patch no longer applies cleanly. error: patch failed: lisp/emacs-lisp/package.el:3262 error: lisp/emacs-lisp/package.el: patch does not apply Some minor comments below. > +;; The terminating comment could be a generic string that is not in English > (unless (search-forward (concat ";;; " file-name ".el ends here")) > (error "Package lacks a terminating comment")) Should that be a FIXME or TODO? > + (message "Packages to hide: %s. Type `%s' to toggle or `%s' to customize" ^ Missing double space > (defun package-menu--list-to-prompt (packages) > +;; The case where `package' is empty is handled in > +;; package-menu--prompt-transation-p below ^ transaction > (defun package-menu--prompt-transaction-p (delete install upgrade) > + (format "%s%s%s%s" This kind of format call is that same as concat, right? > + (if (not delete) "" > + (format "Packages to delete: %s. " (package-menu--list-to-prompt delete))) > + (if (not install) "" > + (format "Packages to install: %s. " (package-menu--list-to-prompt install))) > + (if (not upgrade) "" > + (format "Packages to upgrade: %s. " (package-menu--list-to-prompt upgrade))) > + "Proceed? "))) > + > > @@ -3262,25 +3252,23 @@ package-menu-execute > + (format "[ %s%s%s]" > + (if (not .delete) "" > + (format "Delete %d " (length .delete))) > + (if (not .install) "" > + (format "Install %d " (length .install))) > + (if (not .upgrade) "" > + (format "Upgrade %d " (length .upgrade)))))) Perhaps this one too? (although in this case it would mean splitting up the brackets) > + (message "Operation finished. Packages that are no longer needed: %d. Type `%s' to remove them" ^ ^ Double spacing Double spacing This line is getting pretty long, perhaps it should be broken up?