From: Noam Postavsky <npostavs@gmail.com>
To: Jean-Christophe Helary <jean.christophe.helary@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: package.el strings
Date: Wed, 25 Apr 2018 21:10:05 -0400 [thread overview]
Message-ID: <87lgdarcwi.fsf@gmail.com> (raw)
In-Reply-To: <84FCCBF3-F20F-48E2-B05E-F6DB218D8896@gmail.com> (Jean-Christophe Helary's message of "Wed, 18 Apr 2018 15:38:26 +0900")
> Almost 9 months and nothing in master. Was there anything wrong with
> the code?
I think the problem is more a lack of people who "make changes in
package.el". Although there's enough that your patch no longer applies
cleanly.
error: patch failed: lisp/emacs-lisp/package.el:3262
error: lisp/emacs-lisp/package.el: patch does not apply
Some minor comments below.
> +;; The terminating comment could be a generic string that is not in English
> (unless (search-forward (concat ";;; " file-name ".el ends here"))
> (error "Package lacks a terminating comment"))
Should that be a FIXME or TODO?
> + (message "Packages to hide: %s. Type `%s' to toggle or `%s' to customize"
^
Missing double space
> (defun package-menu--list-to-prompt (packages)
> +;; The case where `package' is empty is handled in
> +;; package-menu--prompt-transation-p below
^
transaction
> (defun package-menu--prompt-transaction-p (delete install upgrade)
> + (format "%s%s%s%s"
This kind of format call is that same as concat, right?
> + (if (not delete) ""
> + (format "Packages to delete: %s. " (package-menu--list-to-prompt delete)))
> + (if (not install) ""
> + (format "Packages to install: %s. " (package-menu--list-to-prompt install)))
> + (if (not upgrade) ""
> + (format "Packages to upgrade: %s. " (package-menu--list-to-prompt upgrade)))
> + "Proceed? ")))
> +
>
> @@ -3262,25 +3252,23 @@ package-menu-execute
> + (format "[ %s%s%s]"
> + (if (not .delete) ""
> + (format "Delete %d " (length .delete)))
> + (if (not .install) ""
> + (format "Install %d " (length .install)))
> + (if (not .upgrade) ""
> + (format "Upgrade %d " (length .upgrade))))))
Perhaps this one too? (although in this case it would mean splitting up
the brackets)
> + (message "Operation finished. Packages that are no longer needed: %d. Type `%s' to remove them"
^ ^
Double spacing Double spacing
This line is getting pretty long, perhaps it should be broken up?
next prev parent reply other threads:[~2018-04-26 1:10 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 5:08 package.el strings Jean-Christophe Helary
2017-05-24 11:00 ` Jean-Christophe Helary
2017-05-24 12:04 ` Dmitry Gutov
2017-05-24 12:07 ` Jean-Christophe Helary
2017-05-24 12:36 ` Yuri Khan
2017-05-24 14:16 ` Richard Stallman
2017-07-14 2:53 ` Jean-Christophe Helary
2017-07-15 12:52 ` Eli Zaretskii
2017-07-15 14:48 ` Jean-Christophe Helary
2017-07-16 13:55 ` Jean-Christophe Helary
2017-07-16 14:16 ` Eli Zaretskii
2017-07-16 14:35 ` Eli Zaretskii
2017-07-16 14:37 ` Jean-Christophe Helary
2017-07-17 15:28 ` Jean-Christophe Helary
2017-07-22 9:23 ` Eli Zaretskii
2018-04-18 6:38 ` Jean-Christophe Helary
2018-04-26 1:10 ` Noam Postavsky [this message]
2018-04-26 6:31 ` Jean-Christophe Helary
2018-04-26 11:28 ` Noam Postavsky
2018-04-26 13:32 ` Jean-Christophe Helary
2018-04-28 22:11 ` Noam Postavsky
2018-04-28 23:46 ` Jean-Christophe Helary
2018-05-29 22:38 ` Noam Postavsky
2018-05-29 22:46 ` Jean-Christophe Helary
2018-06-17 14:02 ` Jean-Christophe Helary
2018-06-17 14:33 ` Eli Zaretskii
2018-06-17 14:45 ` Jean-Christophe Helary
2018-06-17 14:50 ` Eli Zaretskii
2018-06-17 14:58 ` Jean-Christophe Helary
2018-06-20 13:53 ` Jean-Christophe Helary
2018-06-20 15:54 ` Eli Zaretskii
2018-06-20 16:19 ` Jean-Christophe Helary
2018-06-24 15:37 ` Noam Postavsky
2018-06-24 21:57 ` Jean-Christophe Helary
2018-06-24 23:09 ` Noam Postavsky
2018-06-25 1:39 ` Jean-Christophe Helary
2018-06-25 23:22 ` Noam Postavsky
2018-06-27 4:21 ` Jean-Christophe Helary
2018-06-27 18:32 ` Noam Postavsky
2018-04-29 19:43 ` Stefan Monnier
2018-04-26 13:40 ` Jean-Christophe Helary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgdarcwi.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=jean.christophe.helary@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.