From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: John Shahid Newsgroups: gmane.emacs.devel Subject: Re: auto-complete popup is broken on master Date: Mon, 25 Jun 2018 17:18:45 +0000 Message-ID: <87lgb2rdhm.fsf@gmail.com> References: <87sh5arhw0.fsf@gmail.com> <87r2kurhn1.fsf@gmail.com> <837emmstl7.fsf@gnu.org> <87po0erekt.fsf@gmail.com> <836026ssor.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1529947480 25414 195.159.176.226 (25 Jun 2018 17:24:40 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 25 Jun 2018 17:24:40 +0000 (UTC) User-Agent: mu4e 1.1.0; emacs 27.0.50 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 25 19:24:36 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXVEB-0006T2-LT for ged-emacs-devel@m.gmane.org; Mon, 25 Jun 2018 19:24:35 +0200 Original-Received: from localhost ([::1]:48494 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXVGJ-0003hw-3C for ged-emacs-devel@m.gmane.org; Mon, 25 Jun 2018 13:26:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49256) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXV8f-0006pj-GT for emacs-devel@gnu.org; Mon, 25 Jun 2018 13:18:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXV8b-0000bL-BN for emacs-devel@gnu.org; Mon, 25 Jun 2018 13:18:53 -0400 Original-Received: from mail-qt0-x231.google.com ([2607:f8b0:400d:c0d::231]:41013) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fXV8b-0000al-4i; Mon, 25 Jun 2018 13:18:49 -0400 Original-Received: by mail-qt0-x231.google.com with SMTP id y20-v6so12632047qto.8; Mon, 25 Jun 2018 10:18:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=/sgn2wTeZCJyxx//13WR20byfBk8KQ+mKWSCEQhbwCY=; b=i2MrQmJLmosXrcRAAbuDmTbdLasoTakVJ1VRreX7FhCrIYNlBDa/785GCrQalO74Ez eT6PmkKT4uNEAe3GEKVCXACzI8BjLU9MQ9+G0rxbWDbQaEPAUeIQOQ1RJbZnNS8TD5zK SVBl0rwu8HsemEa+aTfZR0QdMjBjODKFFGDYzWUz9e/IwrKUavVCAL9vGWjSuh6g+41+ 9gmjzkGKD3QHvSb8Fl8OpaD3ayIjDxzHVjzme7J+cq8XWFuo2+7Cc8gHx9N8/Q6PYiPp TWZftqe2SfFDzUukL+7IxTS4DZgudjAxe8XNV74QPxHEyRS/FajSOB6O4NmKpgaI15ov 6BWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=/sgn2wTeZCJyxx//13WR20byfBk8KQ+mKWSCEQhbwCY=; b=KHnUeKLFqnR/pdgnQ01SIQmGiAna6nJZSj5NEPHPApB63styqZ6lO1qsIFSknYWViG 0tTAmbv5QrrTxtmmW3ZBema7afsqGLk9i8h9imAUCsD9n2gH69VBPr8aVJ/7VI7fcT7i zehEAP6RcNWoIfu2rsYqxdU/T3LkLZpH03a+lzRBzmz5+RBkwsO6PqhWSTUA/kzmsZnI r+6lqyOpJ6pLJPr3h8H0zN/H4kuCTkpHUuVp0/F0dgFOLMkQ57bJuwOnvf4IwQxaVQvq C9pLXEeM9lsgbSDkKPt6R2W1FwJZ0zzr4YFRGBHz6tnxsuDuQBxOUJPLxZdlbQ6SPnB3 PaEg== X-Gm-Message-State: APt69E1eChSC9dxCMMF/t1pSl8VHA8SXVrz2z8B9kCu+YRDTu+MQCLbv H21lrblSlMM0DMEahDrzItTaa0J7 X-Google-Smtp-Source: AAOMgpdC9MnrPUQUObuznZ+ELkGc2OUDVJtCVMe2bW48jggHtI+97QJlYjxWlsB4J9imUwIXrGxtfA== X-Received: by 2002:a0c:f9ca:: with SMTP id j10-v6mr11841057qvo.25.1529947127939; Mon, 25 Jun 2018 10:18:47 -0700 (PDT) Original-Received: from 146f2c17b146 (cpe-184-152-55-93.nyc.res.rr.com. [184.152.55.93]) by smtp.gmail.com with ESMTPSA id k8-v6sm11984987qti.4.2018.06.25.10.18.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Jun 2018 10:18:47 -0700 (PDT) In-reply-to: <836026ssor.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226727 Archived-At: Eli Zaretskii writes: >> From: John Shahid >> Cc: Emacs-Devel devel >> Date: Mon, 25 Jun 2018 16:55:14 +0000 >> >> >> >> While debugging this issue I also noticed that auto-complete popup-el >> >> use overlay 'prefix property which isn't documented. >> > >> > Can you point at places in auto-complete which are using that >> > property? >> >> It is being set in the following places >> https://github.com/auto-complete/popup-el/blob/master/popup.el#L610 & >> https://github.com/auto-complete/popup-el/blob/master/popup.el#L366. > > That seems just a private property used by the package: it is used in > popup-set-line-item. Right? You are absolutely right. That was an oversight on my end. The issue with auto-complete popup seems to be caused by the change in behavior of `vertical-motion' and having `display-line-number' mode on. The prefix property has nothing to do with the issue I described. FYI, I created bug#31966. cheers, -js