From: Stephen Berman <stephen.berman@gmx.net>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: Byte-compiler warnings for todo-mode.el
Date: Mon, 06 Aug 2018 18:30:55 +0200 [thread overview]
Message-ID: <87lg9jmp8g.fsf@rub.de> (raw)
In-Reply-To: <jwv36vrfr7t.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 06 Aug 2018 11:32:28 -0400")
On Mon, 06 Aug 2018 11:32:28 -0400 Stefan Monnier <monnier@IRO.UMontreal.CA> wrote:
>> ...starting emacs -Q with the above code and my ~/.emacs.d/todo/
>> directory, typing `F f' in todo-mode prompts for a filtered items file
>> and repeating M-n brings up all and only the names of my filtered items
>> files in the minibuffer, i.e., all and only the elements of sfnlist.
>
> No, M-n gives you the elements of falist. Try M-p
(M-n actually shows the cars of the elements of falist.) I see now that
I was unaware that M-n shows the list of default values if the history
is empty (the doc string doesn't say this but the Emacs manual does), so
I was laboring under a mistaken understanding. Thanks for making me see
the light.
> BTW, what this also means is that you shouldn't pre-populate sfnlist
> with the elements of falist. Instead, call it todo--something-history,
> make it a global variable, and don't touch it yourself at all.
Yes, this works well, thanks.
>>>> The warning can be prevented with (eval-and-compile (require 'hl-line)).
>>> This ideally shouldn't remove the warning (i.e. if it does, as you say,
>>> then it's probably the result of a bug or misfeature in the compiler).
>> When I replace the above if-sexp with this:
>> (when (and (eval-and-compile (require 'hl-line)) hl-line-mode)
>> (hl-line-highlight))
>> and byte-compile the file in emacs -Q, Emacs does not produce the
>> warning. Should I make a bug report?
>
> Sorry, I thought you had written eval-when-compile.
> With eval-and-compile it's normal and correct that the warning disappears.
Ah, ok.
Steve Berman
prev parent reply other threads:[~2018-08-06 16:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-05 20:57 Byte-compiler warnings for todo-mode.el Stephen Berman
2018-08-06 1:23 ` Stefan Monnier
2018-08-06 8:49 ` Stephen Berman
2018-08-06 15:32 ` Stefan Monnier
2018-08-06 15:56 ` Stefan Monnier
2018-08-06 16:30 ` Stephen Berman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg9jmp8g.fsf@rub.de \
--to=stephen.berman@gmx.net \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.